Adapt to React api: add context argument to compat/Children map api #3855
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thompson1985
approved these changes
Oct 6, 2024
React's children api map function supports a "context" argument that we don't. See preactjs#2644.
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
rschristian
approved these changes
Aug 6, 2025
Member
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
Sorry this sat for so long but we appreciate it!
kigiri
reviewed
Dec 8, 2025
| const mapFn = (children, fn, context) => { | ||
| if (children == null) return null; | ||
| return toChildArray(toChildArray(children).map(fn)); | ||
| return toChildArray(toChildArray(children).map(fn.bind(context))); |
There was a problem hiding this comment.
we don't need to bind here no ?
toChildArray(toChildArray(children).map(fn, context))Map accept the context as a secondary argument already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React's children api map function supports a "context" argument that we don't.
Fixes #2644.
Based mostly on #2645.
There was a problem though: When I ran
npm run test:karma, it didn't testChildren.test.js. Even the pipeline on the forked project didn't runChildren.test.js. I couldn't figure it out. Don't know if this is an issue or just misconfiguration.