Skip to content

ownerDocument (rebased) #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
developit wants to merge 30 commits into from
Closed

ownerDocument (rebased) #3042

developit wants to merge 30 commits into from

Conversation

@developit
Copy link
Member

@developit developit commented Feb 23, 2021

No description provided.

Hydrophobefireman and others added 26 commits June 3, 2020 20:35
@Hydrophobefireman
Get document from parentNode.ownerDocument instead of relying on glob…
7212bde 
…al (Fixes #2545)
@Hydrophobefireman
pass the ownerDocument to diffElementNodes
6081903
@Hydrophobefireman
add JSDoc
7cbdd3f
@Hydrophobefireman
fix indents
2b6b2f2
@Hydrophobefireman @JoviDeCroock
Update src/diff/index.js
ece8120 
Co-authored-by: Jovi De Croock <[email protected]>
@Hydrophobefireman
remove unused variable
92e9eb3
@Hydrophobefireman
pass ownerDocument to diff function
a47d972
@Hydrophobefireman
check if ownerDocument is equal to document
e304816
@Hydrophobefireman
check spy.get
6e858dd
@Hydrophobefireman
prevent multiple gets of ownerDocument
799f08e
@Hydrophobefireman
fix ownerDocument being null when passed down to diff()
d54a8bb
@Hydrophobefireman
remove unused variable
f0dd5e7
@Hydrophobefireman
prevent repeated access of parentNode.ownerDocument
de068ad
@Hydrophobefireman
run tests for an iframe
a013f08
@Hydrophobefireman
remove unused import
c3e0a29
@Hydrophobefireman
Delete index.js.rej
6b5a973
@Hydrophobefireman
check ownerDocument of the rendered textNode
5251ff1
@Hydrophobefireman
revert changes to test command
894b654
@developit
Merge branch 'master' into patch-1
c71b07a
@Hydrophobefireman
add spy on createTextNode
265c2e2
@Hydrophobefireman
Merge branch 'patch-1' of github.com:Hydrophobefireman/preact into pa…
a5343d8 
…tch-1
@Hydrophobefireman
Merge branch 'master' into patch-1
83f3835
@Hydrophobefireman
Merge branch 'patch-1' of github.com:Hydrophobefireman/preact into pa…
b9f0e2c 
…tch-1
@JoviDeCroock
Merge branch 'master' into patch-1
6c05b25
@Hydrophobefireman
Merge branch 'master' into patch-1
44233c0
@developit
Merge branch 'patch-1' of https://github.com/Hydrophobefireman/preact …
6c06b12 
…into Hydrophobefireman-patch-1
@github-actions
Copy link

github-actions bot commented Feb 23, 2021 •
edited by andrewiggins
Loading

Old results (didn't merge well):

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -4% - +1% (-6.07ms - +2.01ms)
    preact-local vs preact-master
  • 02_replace1k: unsure 🔍 -13% - +2% (-16.77ms - +3.27ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.55ms - +1.81ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-2.29ms - +0.76ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.83ms - +3.76ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-13.10ms - +10.89ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -9% - +4% (-3.51ms - +1.68ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +1% (-0.29ms - +0.29ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +3% (-1.14ms - +3.42ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-1.56ms - +0.12ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +16% (-1.80ms - +11.82ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +3% (-0.67ms - +0.82ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +4% (-0.16ms - +0.14ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-master
  • todo: slower ❌ 0% - 2% (0.10ms - 0.99ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-master
  • 02_replace1k: unsure 🔍 -2% - +12% (-0.08ms - +0.43ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.03ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +5% (-0.40ms - +0.79ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master155.10ms - 160.88ms-unsure 🔍
-1% - +4%
-2.01ms - +6.07ms
preact-local153.14ms - 158.79msunsure 🔍
-4% - +1%
-6.07ms - +2.01ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.76ms - 3.78ms-unsure 🔍
-0% - +1%
-0.00ms - +0.02ms
preact-local3.75ms - 3.77msunsure 🔍
-1% - +0%
-0.02ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master50.63ms - 51.35ms-slower ❌
0% - 2%
0.18ms - 1.16ms
preact-local49.98ms - 50.65msfaster ✔
0% - 2%
0.18ms - 1.16ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master79.60ms - 83.72ms-unsure 🔍
-7% - -0%
-6.34ms - +0.04ms
preact-local82.38ms - 87.24msunsure 🔍
-0% - +8%
-0.04ms - +6.34ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master56.41ms - 61.17ms-unsure 🔍
-7% - +4%
-4.44ms - +2.34ms
preact-local57.43ms - 62.26msunsure 🔍
-4% - +8%
-2.34ms - +4.44ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master59.01ms - 65.18ms-unsure 🔍
-1% - +14%
-0.29ms - +8.04ms
preact-local55.43ms - 61.02msunsure 🔍
-13% - +0%
-8.04ms - +0.29ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master109.24ms - 121.01ms-unsure 🔍
-9% - +4%
-10.57ms - +5.13ms
preact-local112.65ms - 123.04msunsure 🔍
-5% - +9%
-5.13ms - +10.57ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master38.96ms - 43.60ms-unsure 🔍
-5% - +11%
-1.91ms - +4.35ms
preact-local37.96ms - 42.16msunsure 🔍
-10% - +5%
-4.35ms - +1.91ms		-
02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master125.89ms - 137.82ms-unsure 🔍
-3% - +14%
-3.27ms - +16.77ms		unsure 🔍
-4% - +12%
-4.27ms - +15.20ms
preact-local117.05ms - 133.15msunsure 🔍
-13% - +2%
-16.77ms - +3.27ms		-unsure 🔍
-10% - +8%
-12.41ms - +9.85ms
preact-hooks118.69ms - 134.08msunsure 🔍
-11% - +3%
-15.20ms - +4.27ms		unsure 🔍
-8% - +10%
-9.85ms - +12.41ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.60ms - 3.90ms-unsure 🔍
-11% - +2%
-0.43ms - +0.08ms		unsure 🔍
-9% - +3%
-0.37ms - +0.11ms
preact-local3.72ms - 4.13msunsure 🔍
-2% - +12%
-0.08ms - +0.43ms		-unsure 🔍
-6% - +8%
-0.23ms - +0.32ms
preact-hooks3.70ms - 4.07msunsure 🔍
-3% - +10%
-0.11ms - +0.37ms		unsure 🔍
-8% - +6%
-0.32ms - +0.23ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.01ms - 1.05ms-unsure 🔍
-5% - +2%
-0.05ms - +0.03ms		unsure 🔍
-8% - +1%
-0.08ms - +0.01ms
preact-local1.01ms - 1.07msunsure 🔍
-2% - +5%
-0.03ms - +0.05ms		-unsure 🔍
-7% - +3%
-0.08ms - +0.03ms
preact-hooks1.03ms - 1.11msunsure 🔍
-1% - +8%
-0.01ms - +0.08ms		unsure 🔍
-3% - +7%
-0.03ms - +0.08ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.67ms - 1.03ms-unsure 🔍
-19% - +41%
-0.14ms - +0.30ms		unsure 🔍
-10% - +54%
-0.06ms - +0.36ms
preact-local0.64ms - 0.90msunsure 🔍
-34% - +15%
-0.30ms - +0.14ms		-unsure 🔍
-16% - +36%
-0.10ms - +0.24ms
preact-hooks0.58ms - 0.81msunsure 🔍
-40% - +3%
-0.36ms - +0.06ms		unsure 🔍
-31% - +12%
-0.24ms - +0.10ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.40ms - 0.50ms-unsure 🔍
-15% - +10%
-0.07ms - +0.05ms		unsure 🔍
-6% - +20%
-0.03ms - +0.08ms
preact-local0.43ms - 0.48msunsure 🔍
-11% - +15%
-0.05ms - +0.07ms		-slower ❌
1% - 18%
0.00ms - 0.07ms
preact-hooks0.40ms - 0.44msunsure 🔍
-18% - +5%
-0.08ms - +0.03ms		faster ✔
1% - 16%
0.00ms - 0.07ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.39ms - 0.76ms-unsure 🔍
-38% - +60%
-0.19ms - +0.30ms		unsure 🔍
-62% - +18%
-0.52ms - +0.19ms
preact-local0.36ms - 0.68msunsure 🔍
-50% - +30%
-0.30ms - +0.19ms		-unsure 🔍
-66% - +6%
-0.57ms - +0.12ms
preact-hooks0.44ms - 1.05msunsure 🔍
-38% - +95%
-0.19ms - +0.52ms		unsure 🔍
-30% - +116%
-0.12ms - +0.57ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.29ms - 0.34ms-unsure 🔍
-14% - +11%
-0.04ms - +0.03ms		unsure 🔍
-11% - +10%
-0.04ms - +0.03ms
preact-local0.29ms - 0.35msunsure 🔍
-11% - +14%
-0.03ms - +0.04ms		-unsure 🔍
-10% - +11%
-0.03ms - +0.03ms
preact-hooks0.30ms - 0.34msunsure 🔍
-10% - +12%
-0.03ms - +0.04ms		unsure 🔍
-11% - +10%
-0.03ms - +0.03ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.27ms - 0.36ms-unsure 🔍
-29% - +4%
-0.11ms - +0.02ms		unsure 🔍
-30% - +4%
-0.12ms - +0.02ms
preact-local0.32ms - 0.41msunsure 🔍
-7% - +36%
-0.02ms - +0.11ms		-unsure 🔍
-19% - +18%
-0.07ms - +0.07ms
preact-hooks0.31ms - 0.41msunsure 🔍
-8% - +38%
-0.02ms - +0.12ms		unsure 🔍
-19% - +19%
-0.07ms - +0.07ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master38.03ms - 39.83ms-unsure 🔍
-5% - +4%
-1.81ms - +1.55ms
preact-local37.64ms - 40.48msunsure 🔍
-4% - +5%
-1.55ms - +1.81ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.65ms - 3.65ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local3.65ms - 3.65msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master42.49ms - 44.72ms-unsure 🔍
-2% - +5%
-0.76ms - +2.29ms		unsure 🔍
-3% - +4%
-1.23ms - +1.84ms
preact-local41.80ms - 43.88msunsure 🔍
-5% - +2%
-2.29ms - +0.76ms		-unsure 🔍
-4% - +2%
-1.94ms - +1.03ms
preact-hooks42.24ms - 44.35msunsure 🔍
-4% - +3%
-1.84ms - +1.23ms		unsure 🔍
-2% - +5%
-1.03ms - +1.94ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.46ms - 3.46ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms		faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local3.46ms - 3.47msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.48ms - 3.49msslower ❌
0% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1238.91ms - 1242.12ms-unsure 🔍
-0% - +0%
-3.76ms - +0.83ms
preact-local1240.33ms - 1243.63msunsure 🔍
-0% - +0%
-0.83ms - +3.76ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.59ms - 25.59ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.59ms - 25.59msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1863.43ms - 1879.98ms-unsure 🔍
-1% - +1%
-10.89ms - +13.10ms		faster ✔
0% - 1%
0.63ms - 24.67ms
preact-local1861.93ms - 1879.28msunsure 🔍
-1% - +1%
-13.10ms - +10.89ms		-faster ✔
0% - 1%
1.46ms - 26.06ms
preact-hooks1875.64ms - 1893.08msslower ❌
0% - 1%
0.63ms - 24.67ms		slower ❌
0% - 1%
1.46ms - 26.06ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.51ms - 25.52ms-unsure 🔍
-0% - +0%
-0.00ms - +0.03ms		unsure 🔍
-0% - -0%
-0.03ms - -0.01ms
preact-local25.49ms - 25.52msunsure 🔍
-0% - +0%
-0.03ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.05ms - -0.01ms
preact-hooks25.52ms - 25.54msunsure 🔍
+0% - +0%
+0.01ms - +0.03ms		unsure 🔍
+0% - +0%
+0.01ms - +0.05ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master39.01ms - 42.73ms-unsure 🔍
-4% - +9%
-1.68ms - +3.51ms
preact-local38.15ms - 41.77msunsure 🔍
-9% - +4%
-3.51ms - +1.68ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.81ms - 1.82ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-local1.81ms - 1.82msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master23.25ms - 23.65ms-unsure 🔍
-1% - +1%
-0.29ms - +0.29ms		unsure 🔍
-3% - +1%
-0.80ms - +0.19ms
preact-local23.25ms - 23.66msunsure 🔍
-1% - +1%
-0.29ms - +0.29ms		-unsure 🔍
-3% - +1%
-0.80ms - +0.20ms
preact-hooks23.30ms - 24.21msunsure 🔍
-1% - +3%
-0.19ms - +0.80ms		unsure 🔍
-1% - +3%
-0.20ms - +0.80ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.61ms - 1.61ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.61ms - 1.61msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.63ms - 1.63msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master117.10ms - 120.51ms-unsure 🔍
-3% - +1%
-3.42ms - +1.14ms
preact-local118.43ms - 121.46msunsure 🔍
-1% - +3%
-1.14ms - +3.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.42ms - 6.45ms-unsure 🔍
-0% - +0%
-0.01ms - +0.03ms
preact-local6.41ms - 6.44msunsure 🔍
-0% - +0%
-0.03ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master121.75ms - 122.99ms-unsure 🔍
-0% - +1%
-0.12ms - +1.56ms		unsure 🔍
-1% - +0%
-1.27ms - +0.40ms
preact-local121.07ms - 122.22msunsure 🔍
-1% - +0%
-1.56ms - +0.12ms		-faster ✔
0% - 2%
0.36ms - 1.96ms
preact-hooks122.25ms - 123.37msunsure 🔍
-0% - +1%
-0.40ms - +1.27ms		slower ❌
0% - 2%
0.36ms - 1.96ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master14.88ms - 15.71ms-unsure 🔍
-5% - +3%
-0.79ms - +0.40ms		unsure 🔍
-3% - +5%
-0.43ms - +0.71ms
preact-local15.07ms - 15.92msunsure 🔍
-3% - +5%
-0.40ms - +0.79ms		-unsure 🔍
-2% - +6%
-0.24ms - +0.92ms
preact-hooks14.76ms - 15.55msunsure 🔍
-5% - +3%
-0.71ms - +0.43ms		unsure 🔍
-6% - +2%
-0.92ms - +0.24ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master72.42ms - 82.06ms-unsure 🔍
-14% - +2%
-11.82ms - +1.80ms
preact-local77.44ms - 87.06msunsure 🔍
-3% - +16%
-1.80ms - +11.82ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.87ms - 4.87ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local4.87ms - 4.87msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master23.03ms - 24.06ms-unsure 🔍
-3% - +3%
-0.82ms - +0.67ms		unsure 🔍
-4% - +2%
-0.90ms - +0.49ms
preact-local23.08ms - 24.16msunsure 🔍
-3% - +3%
-0.67ms - +0.82ms		-unsure 🔍
-4% - +2%
-0.84ms - +0.58ms
preact-hooks23.29ms - 24.21msunsure 🔍
-2% - +4%
-0.49ms - +0.90ms		unsure 🔍
-2% - +4%
-0.58ms - +0.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.65ms - 4.65ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.65ms - 4.65msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.67ms - 4.67msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.55ms - 3.71ms-unsure 🔍
-4% - +5%
-0.14ms - +0.16ms
preact-local3.49ms - 3.74msunsure 🔍
-5% - +4%
-0.16ms - +0.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.04ms - 1.04ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local1.04ms - 1.04msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.89ms - 2.92ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms		faster ✔
4% - 6%
0.12ms - 0.17ms
preact-local2.89ms - 2.92msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-faster ✔
4% - 6%
0.12ms - 0.17ms
preact-hooks3.04ms - 3.07msslower ❌
4% - 6%
0.12ms - 0.17ms		slower ❌
4% - 6%
0.12ms - 0.17ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.82ms - 0.82ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		faster ✔
2% - 2%
0.01ms - 0.01ms
preact-local0.82ms - 0.82msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-faster ✔
2% - 2%
0.01ms - 0.01ms
preact-hooks0.84ms - 0.84msslower ❌
2% - 2%
0.01ms - 0.01ms		slower ❌
2% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master60.80ms - 61.47ms-faster ✔
0% - 2%
0.10ms - 0.99ms		faster ✔
1% - 3%
0.81ms - 1.88ms
preact-local61.38ms - 61.97msslower ❌
0% - 2%
0.10ms - 0.99ms		-faster ✔
0% - 2%
0.29ms - 1.31ms
preact-hooks62.06ms - 62.89msslower ❌
1% - 3%
0.81ms - 1.88ms		slower ❌
0% - 2%
0.29ms - 1.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.11ms - 1.11ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local1.11ms - 1.11msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
2% - 3%
0.03ms - 0.03ms
preact-hooks1.14ms - 1.14msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
2% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 (frozen) for Benchmarks

@developit developit changed the title ownerdocument-rebased ownerDocument (rebased) Feb 23, 2021
@github-actions
Copy link

github-actions bot commented Feb 23, 2021 •
edited
Loading

Size Change: +127 B (0%)

Total Size: 53.1 kB

Filename Size Change
compat/dist/compat.js 3.82 kB +11 B (0%)
compat/dist/compat.module.js 3.76 kB +11 B (0%)
compat/dist/compat.umd.js 3.89 kB +13 B (0%)
dist/preact.js 4.07 kB +10 B (0%)
dist/preact.min.js 4.09 kB +16 B (0%)
dist/preact.min.module.js 4.09 kB +20 B (0%)
dist/preact.min.umd.js 4.12 kB +17 B (0%)
dist/preact.module.js 4.08 kB +15 B (0%)
dist/preact.umd.js 4.13 kB +14 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 358 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 324 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 439 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 4, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 99.531% when pulling 51781c0 on ownerdocument-rebased into a31e564 on master.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -11% - +7% (-19.43ms - +12.15ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +4% (-1.38ms - +1.61ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +0% (-12.52ms - +4.01ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +1% (-0.12ms - +0.34ms)
    preact-local vs preact-master
  • hydrate1k: slower ❌ 0% - 2% (0.05ms - 2.04ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +1% (-1.53ms - +0.30ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +2% (-0.14ms - +0.06ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -2% - +2% (-0.83ms - +1.18ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -7% - +9% (-0.26ms - +0.33ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 +0% - +0% (+0.00ms - +0.02ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.02ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +6% (-0.29ms - +0.85ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master168.18ms - 188.71ms-unsure 🔍
-7% - +11%
-12.15ms - +19.43ms		unsure 🔍
-4% - +15%
-6.87ms - +24.39ms
preact-local162.81ms - 186.80msunsure 🔍
-11% - +7%
-19.43ms - +12.15ms		-unsure 🔍
-7% - +13%
-11.69ms - +21.94ms
preact-hooks157.90ms - 181.46msunsure 🔍
-13% - +4%
-24.39ms - +6.87ms		unsure 🔍
-12% - +7%
-21.94ms - +11.69ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.67ms - 4.11ms-unsure 🔍
-8% - +7%
-0.33ms - +0.26ms		unsure 🔍
-15% - +2%
-0.62ms - +0.10ms
preact-local3.72ms - 4.13msunsure 🔍
-7% - +9%
-0.26ms - +0.33ms		-unsure 🔍
-14% - +3%
-0.57ms - +0.12ms
preact-hooks3.87ms - 4.43msunsure 🔍
-3% - +16%
-0.10ms - +0.62ms		unsure 🔍
-3% - +15%
-0.12ms - +0.57ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.30ms - 1.40ms-unsure 🔍
-4% - +7%
-0.05ms - +0.09ms		unsure 🔍
-7% - +4%
-0.10ms - +0.05ms
preact-local1.29ms - 1.37msunsure 🔍
-6% - +4%
-0.09ms - +0.05ms		-unsure 🔍
-8% - +2%
-0.11ms - +0.03ms
preact-hooks1.32ms - 1.42msunsure 🔍
-4% - +7%
-0.05ms - +0.10ms		unsure 🔍
-2% - +8%
-0.03ms - +0.11ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.76ms - 1.15ms-unsure 🔍
-21% - +29%
-0.19ms - +0.26ms		unsure 🔍
-35% - +8%
-0.40ms - +0.10ms
preact-local0.80ms - 1.04msunsure 🔍
-27% - +20%
-0.26ms - +0.19ms		-unsure 🔍
-33% - -0%
-0.39ms - +0.02ms
preact-hooks0.94ms - 1.27msunsure 🔍
-13% - +45%
-0.10ms - +0.40ms		unsure 🔍
-4% - +44%
-0.02ms - +0.39ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.50ms - 0.64ms-unsure 🔍
-12% - +22%
-0.06ms - +0.12ms		unsure 🔍
-23% - +17%
-0.14ms - +0.10ms
preact-local0.49ms - 0.59msunsure 🔍
-20% - +10%
-0.12ms - +0.06ms		-unsure 🔍
-26% - +11%
-0.16ms - +0.07ms
preact-hooks0.49ms - 0.68msunsure 🔍
-19% - +25%
-0.10ms - +0.14ms		unsure 🔍
-13% - +29%
-0.07ms - +0.16ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.49ms - 1.07ms-unsure 🔍
-55% - +41%
-0.48ms - +0.36ms		unsure 🔍
-68% - +10%
-0.85ms - +0.21ms
preact-local0.54ms - 1.14msunsure 🔍
-48% - +64%
-0.36ms - +0.48ms		-unsure 🔍
-65% - +18%
-0.79ms - +0.28ms
preact-hooks0.66ms - 1.54msunsure 🔍
-37% - +118%
-0.21ms - +0.85ms		unsure 🔍
-40% - +101%
-0.28ms - +0.79ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.33ms - 0.45ms-unsure 🔍
-17% - +24%
-0.06ms - +0.09ms		unsure 🔍
-21% - +21%
-0.08ms - +0.08ms
preact-local0.33ms - 0.43msunsure 🔍
-23% - +16%
-0.09ms - +0.06ms		-unsure 🔍
-21% - +15%
-0.09ms - +0.06ms
preact-hooks0.34ms - 0.45msunsure 🔍
-21% - +21%
-0.08ms - +0.08ms		unsure 🔍
-16% - +23%
-0.06ms - +0.09ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.37ms - 0.49ms-unsure 🔍
-27% - +10%
-0.13ms - +0.05ms		unsure 🔍
-12% - +27%
-0.05ms - +0.10ms
preact-local0.40ms - 0.53msunsure 🔍
-12% - +31%
-0.05ms - +0.13ms		-unsure 🔍
-4% - +39%
-0.01ms - +0.15ms
preact-hooks0.35ms - 0.44msunsure 🔍
-24% - +10%
-0.10ms - +0.05ms		unsure 🔍
-30% - +1%
-0.15ms - +0.01ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master36.73ms - 38.89ms-unsure 🔍
-4% - +4%
-1.61ms - +1.38ms		unsure 🔍
-5% - +4%
-1.78ms - +1.49ms
preact-local36.89ms - 38.96msunsure 🔍
-4% - +4%
-1.38ms - +1.61ms		-unsure 🔍
-4% - +4%
-1.64ms - +1.58ms
preact-hooks36.72ms - 39.18msunsure 🔍
-4% - +5%
-1.49ms - +1.78ms		unsure 🔍
-4% - +4%
-1.58ms - +1.64ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.45ms - 3.46ms-unsure 🔍
-0% - -0%
-0.02ms - -0.00ms		faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local3.46ms - 3.47msunsure 🔍
+0% - +0%
+0.00ms - +0.02ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.48ms - 3.49msslower ❌
0% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1305.86ms - 1319.64ms-unsure 🔍
-0% - +1%
-4.01ms - +12.52ms		unsure 🔍
-1% - +0%
-14.05ms - +4.32ms
preact-local1303.93ms - 1313.05msunsure 🔍
-1% - +0%
-12.52ms - +4.01ms		-faster ✔
0% - 1%
1.53ms - 16.71ms
preact-hooks1311.55ms - 1323.68msunsure 🔍
-0% - +1%
-4.32ms - +14.05ms		slower ❌
0% - 1%
1.53ms - 16.71ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.49ms - 25.52ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms		unsure 🔍
-0% - -0%
-0.04ms - -0.00ms
preact-local25.50ms - 25.52msunsure 🔍
-0% - +0%
-0.01ms - +0.02ms		-unsure 🔍
-0% - +0%
-0.03ms - +0.00ms
preact-hooks25.51ms - 25.54msunsure 🔍
+0% - +0%
+0.00ms - +0.04ms		unsure 🔍
-0% - +0%
-0.00ms - +0.03ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master23.07ms - 23.33ms-unsure 🔍
-1% - +1%
-0.34ms - +0.12ms		unsure 🔍
-1% - +0%
-0.32ms - +0.11ms
preact-local23.12ms - 23.50msunsure 🔍
-1% - +1%
-0.12ms - +0.34ms		-unsure 🔍
-1% - +1%
-0.26ms - +0.26ms
preact-hooks23.13ms - 23.48msunsure 🔍
-0% - +1%
-0.11ms - +0.32ms		unsure 🔍
-1% - +1%
-0.26ms - +0.26ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.61ms - 1.61ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.61ms - 1.61msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.63ms - 1.63msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master124.93ms - 125.98ms-faster ✔
0% - 2%
0.05ms - 2.04ms		faster ✔
0% - 1%
0.26ms - 1.78ms
preact-local125.65ms - 127.34msslower ❌
0% - 2%
0.05ms - 2.04ms		-unsure 🔍
-1% - +1%
-0.98ms - +1.03ms
preact-hooks125.92ms - 127.02msslower ❌
0% - 1%
0.26ms - 1.78ms		unsure 🔍
-1% - +1%
-1.03ms - +0.98ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master14.70ms - 15.49ms-unsure 🔍
-5% - +2%
-0.85ms - +0.29ms		unsure 🔍
-7% - +1%
-1.02ms - +0.17ms
preact-local14.96ms - 15.79msunsure 🔍
-2% - +6%
-0.29ms - +0.85ms		-unsure 🔍
-5% - +3%
-0.75ms - +0.46ms
preact-hooks15.07ms - 15.96msunsure 🔍
-1% - +7%
-0.17ms - +1.02ms		unsure 🔍
-3% - +5%
-0.46ms - +0.75ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master28.70ms - 30.10ms-unsure 🔍
-1% - +5%
-0.30ms - +1.53ms		unsure 🔍
-1% - +5%
-0.27ms - +1.44ms
preact-local28.20ms - 29.37msunsure 🔍
-5% - +1%
-1.53ms - +0.30ms		-unsure 🔍
-3% - +3%
-0.80ms - +0.73ms
preact-hooks28.32ms - 29.31msunsure 🔍
-5% - +1%
-1.44ms - +0.27ms		unsure 🔍
-3% - +3%
-0.73ms - +0.80ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.65ms - 4.65ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.65ms - 4.65msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.67ms - 4.67msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.88ms - 4.03ms-unsure 🔍
-2% - +4%
-0.06ms - +0.14ms		faster ✔
1% - 9%
0.05ms - 0.37ms
preact-local3.84ms - 3.98msunsure 🔍
-4% - +2%
-0.14ms - +0.06ms		-faster ✔
2% - 10%
0.09ms - 0.41ms
preact-hooks4.02ms - 4.31msslower ❌
1% - 10%
0.05ms - 0.37ms		slower ❌
2% - 11%
0.09ms - 0.41ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.82ms - 0.82ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		faster ✔
2% - 2%
0.01ms - 0.01ms
preact-local0.82ms - 0.82msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-faster ✔
2% - 2%
0.01ms - 0.01ms
preact-hooks0.84ms - 0.84msslower ❌
2% - 2%
0.01ms - 0.01ms		slower ❌
2% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.23ms - 56.15ms-unsure 🔍
-2% - +1%
-1.18ms - +0.83ms		faster ✔
0% - 4%
0.21ms - 2.25ms
preact-local55.07ms - 55.66msunsure 🔍
-2% - +2%
-0.83ms - +1.18ms		-faster ✔
1% - 3%
0.60ms - 1.51ms
preact-hooks56.08ms - 56.77msslower ❌
0% - 4%
0.21ms - 2.25ms		slower ❌
1% - 3%
0.60ms - 1.51ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.11ms - 1.11ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 3%
0.02ms - 0.03ms
preact-local1.11ms - 1.11msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 3%
0.02ms - 0.03ms
preact-hooks1.13ms - 1.14msslower ❌
2% - 3%
0.02ms - 0.03ms		slower ❌
2% - 3%
0.02ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@JoviDeCroock JoviDeCroock mentioned this pull request Sep 16, 2024
Closed
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 24, 2025
Merged
@JoviDeCroock
Copy link
Member

JoviDeCroock commented Jul 26, 2025

Implemented in #4851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@developit @coveralls @JoviDeCroock @marvinhagemeister @Hydrophobefireman @andrewiggins