fix(#2644): adapt the react children api #2645
Conversation
|
I still have to adjust the tests. |
|
I think that is relevant too ... https://reactjs.org/docs/react-api.html#reactchildren |
|
I hadn't seen that. I feel like a beginner.
|
|
No worries, like mentioned on twitter the |
| expect(serializeHtml(scratch)).to.equal('<div></div>'); | ||
| }); | ||
|
|
||
| it('should propagate the this context', () => { |
There was a problem hiding this comment.
This is a great start, but I think the commit isn't complete. The test defines a few functions but never calls them anywhere. This will make the test always pass, even against current master and without the changes in this PR.
| it('should propagate the this context', () => { | |
| it('should propagate this context', () => { | |
| const context = {}; | |
| const spy = sinon.spy(child => child); // noop | |
| const Foo = ({ children }) => { | |
| return React.Children.map(children, spy, context); | |
| }; | |
| render(<Foo>foo</Foo>, scratch); | |
| expect(spy.thisValues[0]).to.equal(context); | |
| }); |
| return toChildArray(toChildArray(children).map(fn)); | ||
| const mapFn = (children, fn, context) => { | ||
| if (!children) return null; | ||
| return toChildArray(children).reduce( |
There was a problem hiding this comment.
We don't generally use reduce(). I'd prefer to use .map(fn.bind(ctx)) for size and perf reasons.
|
Superseded by #3855 |
5 participants
Fixes #2644 .