Backport some v11 optimizations (#4967)

JoviDeCroock · ali-garajian · Ali Garajian · web-flow · commit 4d40e96f43cd · 2025-11-29T14:19:48.000+01:00
* refactor(children): remove redundant assignment to childVNode (#4951) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(diff): no need to reset props and context when creating component (#4954) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key * refactor(diff): no need to reset props and context when creating component --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(children): remove redundant assignment to oldVNode (#4956) Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(diff): set oldProps default value on declaration (#4959) --------- Co-authored-by: Ali Garajian <50337133+ali-garajian@users.noreply.github.com> Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -218,7 +218,7 @@ function constructNewChildrenArray(
 				childVNode._original
 			);
 		} else {
-			childVNode = newParentVNode._children[i] = childVNode;
+			newParentVNode._children[i] = childVNode;
 		}
 
 		const skewedIndex = i + skew;
@@ -235,7 +235,6 @@ function constructNewChildrenArray(
 			remainingOldChildren
 		));
 
-		oldVNode = NULL;
 		if (matchingIndex != -1) {
 			oldVNode = oldChildren[matchingIndex];
 			remainingOldChildren--;
@@ -426,7 +425,7 @@ function findMatchingIndex(
 		remainingOldChildren > (matched ? 1 : 0);
 
 	if (
-		(oldVNode === NULL && childVNode.key == null) ||
+		(oldVNode === NULL && key == null) ||
 		(matched && key == oldVNode.key && type == oldVNode.type)
 	) {
 		return skewedIndex;
diff --git a/src/diff/index.js b/src/diff/index.js
@@ -112,9 +112,7 @@ export function diff(
 				}
 				if (provider) provider.sub(c);
 
-				c.props = newProps;
 				if (!c.state) c.state = {};
-				c.context = componentContext;
 				c._globalContext = globalContext;
 				isNew = c._dirty = true;
 				c._renderCallbacks = [];
@@ -417,7 +415,7 @@ function diffElementNodes(
 	isHydrating,
 	refQueue
 ) {
-	let oldProps = oldVNode.props;
+	let oldProps = oldVNode.props || EMPTY_OBJ;
 	let newProps = newVNode.props;
 	let nodeType = /** @type {string} */ (newVNode.type);
 	/** @type {any} */
@@ -487,8 +485,6 @@ function diffElementNodes(
 		// If excessDomChildren was not null, repopulate it with the current element's children:
 		excessDomChildren = excessDomChildren && slice.call(dom.childNodes);
 
-		oldProps = oldVNode.props || EMPTY_OBJ;
-
 		// If we are in a situation where we are not hydrating but are using
 		// existing DOM (e.g. replaceNode) we should read the existing DOM
 		// attributes to diff them
