refactor: Move 'clean' script call to target branch#129
Merged
rschristian merged 1 commit intomasterfrom Dec 15, 2025
Merged
Conversation
|
Size Change: 0 B Total Size: 76 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relatively minor but improves DX and reduces headaches considerably, IMO.
The issue with running the
cleanscript against the base branch, rather than target, is that it's always a PR behind; I can't add a newcleanscript in mypackage.jsonAND tell compressed-size to use it all in one go, as the new script will only exist on the target branch & NPM will error out when trying to run it on the base.I think moving it up so that it's the last action ran against the target branch, instead of the first against the base, makes far more sense and makes it easier for users to make changes like this. Users will be able to edit their action config & scripts to keep them in-sync all at once.