feat: Add 'sort-by' option#124
Merged
rschristian merged 1 commit intomasterfrom Nov 17, 2025
Merged
Conversation
|
Size Change: 0 B Total Size: 76 kB ℹ️ View Unchanged
|
rschristian
commented
Nov 17, 2025
Comment on lines
8
to
-12
| | Filename | Size | Change | | | ||
| | :--- | :---: | :---: | :---: | | ||
| | \`four.js\` | 4.5 kB | +9 B (+0.2%) | | | ||
| | \`one.js\` | 5 kB | +2.5 kB (+100%) | 🆘 | | ||
| | \`two.js\` | 5 kB | -2.5 kB (-33.33%) | 🎉 | | ||
| | \`four.js\` | 4.5 kB | +9 B (+0.2%) | | |
Member
Author
There was a problem hiding this comment.
This change (and the similar ones throughout our snapshots) is from a slight inconsistency with our tests.
In a real use case, size-plugin-core generates the list of files that get passed to our diffTable function that will generate the markdown, and the file list it forms is alphabetically sorted. In our test suite, however, we manually build a list of files and pass it directly to diffTable without sorting it beforehand ourselves.
As such, if you had these exact same files in a real app, the order above is the order you'd really see. Previously we relied on sorting happening prior to forming the table is all.
JoviDeCroock
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118