Skip to content

Update all-repos.yaml#684

Closed
JanuszNowak wants to merge 1 commit intopre-commit:mainfrom
Azure4DevOps:main
Closed

Update all-repos.yaml#684
JanuszNowak wants to merge 1 commit intopre-commit:mainfrom
Azure4DevOps:main

Conversation

@JanuszNowak
Copy link
Copy Markdown

@asottile
Copy link
Copy Markdown
Member

  • it's spelled "pre-commit" -- not "Pre-commit"
  • pass_filenames: true is the default
  • language: script hooks miss the point of the framework as they require users to install tools outside of the framework to use them and as such I'm not allowing new ones onto the hooks page

@asottile asottile closed this Jul 14, 2022
@JanuszNowak
Copy link
Copy Markdown
Author

There is no support for powershell, you have hooks like for terraform that also require installation ?

@asottile
Copy link
Copy Markdown
Member

There is no support for powershell, you have hooks like for terraform that also require installation ?

...

not allowing new ones

@JanuszNowak
Copy link
Copy Markdown
Author

@asottile
I fixed to pre-commit, also working on docker version. How can I use additional_dependencies to install all required stall like pip install azure-cli ?

@asottile
Copy link
Copy Markdown
Member

you wouldn't -- you'd use language: python and use actual dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants