Adapt extension of R executable depending on os#2605
Merged
asottile merged 1 commit intopre-commit:mainfrom Dec 12, 2022
Merged
Adapt extension of R executable depending on os#2605asottile merged 1 commit intopre-commit:mainfrom
asottile merged 1 commit intopre-commit:mainfrom
Conversation
lorenzwalthert
changed the title
lorenzwalthert
changed the title
asottile
reviewed
Nov 20, 2022
lorenzwalthert
force-pushed
the
r/fix-exe
branch
from
861be83 to
c0716c0
Compare
Contributor
Author
|
Since the string |
lorenzwalthert
force-pushed
the
r/fix-exe
branch
from
c0716c0 to
53b6e99
Compare
Member
|
I don't think the constant improves things. this should just be a 2 line change (import + changing the call) |
Contributor
Author
|
ok, will revert later. |
lorenzwalthert
force-pushed
the
r/fix-exe
branch
from
53b6e99 to
b859820
Compare
Contributor
Author
|
Seems like the swift installation (unrelated to this PR) is broken... |
Member
yeah there's like ~4 things that have slipped -- I wouldn't worry about it -- I'll be fixing those separately |
Contributor
Author
|
Ok. I think my part is done, I'll rebase once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2599 by adding ensuring
.exesuffix to theRscriptexecutable on Windows. But I don't understand if that change breaks current uses or if some versions of Windows / shells just add `.exe. when it's missing while others don't.Also, I am not sure if it also closes lorenzwalthert/precommit#441 or if the added
~in the Rscript path is of any harm or not andctypes.windll.kernel32.GetLongPathNameWfrom the standard library is needed to use get full path.