Skip to content

Mention that auto-fetching stubs is unsupported#51

Merged
asottile merged 1 commit intopre-commit:masterfrom
WhyNotHugo:patch-1
Jun 28, 2021
Merged

Mention that auto-fetching stubs is unsupported#51
asottile merged 1 commit intopre-commit:masterfrom
WhyNotHugo:patch-1

Conversation

@WhyNotHugo
Copy link
Copy Markdown
Contributor

No description provided.

@asottile
Copy link
Copy Markdown
Member

actually, can you change this to document that this is not supported. mutating pre-commit environments at runtime breaks the cache and can break parallel runs

@WhyNotHugo
Copy link
Copy Markdown
Contributor Author

Good thing I bought it up, now I know.

I'll update the PR to reflect that.

@WhyNotHugo
Copy link
Copy Markdown
Contributor Author

Is there any way to install dependencies from a file (e.g.: typing-requirements.txt) or from an extras? I'd prefer avoiding having to duplicate them inside the pre-commit definitions.

@WhyNotHugo WhyNotHugo changed the title Add hint on fetching type stubes automatically Mention that auto-fetching stubs is unsupported Jun 27, 2021
Copy link
Copy Markdown
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 449ace5 into pre-commit:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants