-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The first request made "is not" cached #627
Comments
Does this observation cause any problems? If not then I don't think we should worry about it. Also the client side cache has been removed in PRAW4. How much have you looked into PRAW4? It would be really awesome to have a prioritized list of what features you require to get your scripts ported so we can move on from PRAW3. |
It hasn't caused any problems for me, just noticed that it was a weird occurrence and could be troublesome in extreme cases (ex, writing a script that goes into reddit unauthenticated to view the logged out /new page of a subreddit (step1), authenticating with oauth to get the logged in view (step2), logging out and then rerequesting the page(step3), then when comparing step1 may not be equal to step3, even though assuming the use of the DefaultHandler it should be). And the fact that it's removed from PRAW4 altogether is a good call in my opinion anyway. |
Let's not worry about it unless it actually results in a bug for someone. I'm not going to say don't try to fix it, but I think there are higher priority things worth spending time on. Closing for now. |
I'm unsure if this is intended or just by consequence. I found this while writing up some tests for a Betamax-like package for python's httplib, and I was comparing responses with those from praw for the sake of ease.
I'll split this up into three scenarios:
Sometimes a session_id cookie is also added, however this seems to be for anonymous tracking purposes and doesn't occur all the time.
Regardless the addition of these cookies make it so that the initial request, when stored in the DefaultHandler's cache, would never be retrieved from the cache (unless you manually manipulate the cookiejar)
The text was updated successfully, but these errors were encountered: