docs(samples): updated samples code to use async await#1
Open
praveenqlogic wants to merge 4 commits intomasterfrom
Open
docs(samples): updated samples code to use async await#1praveenqlogic wants to merge 4 commits intomasterfrom
praveenqlogic wants to merge 4 commits intomasterfrom
Conversation
AVaksman
reviewed
Nov 21, 2018
AVaksman
reviewed
Nov 21, 2018
| .catch(err => { | ||
| // Handle the error. | ||
| }); | ||
| const [clusterResponse, apiResponse] = await cluster.get(); |
There was a problem hiding this comment.
Sorry,
Missed clusterResponse->clusterInstance please
|
|
||
| createRules: (instanceId, tableId) => { | ||
| createRules: async (instanceId, tableId) => { | ||
| const Bigtable = require('@google-cloud/bigtable'); |
There was a problem hiding this comment.
Please move the [START ...] tag above this line
| const snippets = { | ||
| createRow: (instanceId, tableId) => { | ||
| createRow: async (instanceId, tableId) => { | ||
| const Bigtable = require('@google-cloud/bigtable'); |
There was a problem hiding this comment.
Please move the [START ...] tag above this line
romlogic
reviewed
Dec 14, 2018
|
|
||
| const snippets = { | ||
| createRow: (instanceId, tableId) => { | ||
| createRow: async (instanceId, tableId) => { |
There was a problem hiding this comment.
lines 52, 53: If the targeted cell is unset, it will be treated as a containing an
// empty string. Please rephrase it to "If the targeted cell is unset, it will be treated as a cell containing an empty string." Search and change everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)
Fixes https://github.com/googleapis/nodejs-bigtable