Pp add warning and tests #147
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
nevermind, the test I was saying it fails locally is fine, I was using a dev Xarray where I'd mess things up - all fine for me locally: This is with most of the deps installed from conda-forge - see attached env file. I really strongly recommend you folks use conda-forge deps and not PyPI ones, those are always a bit blergh from many causes. Do you want me to pop a conda env file and create the env from that? |
|
ah I can't push to branch, but here is aht I was just about to push: in the GHA workflow, pop a call to a minimal environment file: and get dask (at least) from conda forge in a conda I can help you get those test deps to be test deps in the pyproject toml file afterwards, but I reckon stuff like xarray and dask should definitely be installed in the main dev env and from conda-forge 🍺 |
|
nevermind my blabbering above - I had to go use your full test suite - that test is not from |
| # Zarr2 metadata | ||
| if "axis" not in var.attrs: | ||
| std_axes = ["latitude", "longitude", "time"] | ||
| if not list(set(var.attrs.values()) & set(std_axes)): |
There was a problem hiding this comment.
| if not list(set(var.attrs.values()) & set(std_axes)): | |
| if not [s for s in std_axes if s in str(var.attrs.values())]: |
There was a problem hiding this comment.
this will fix that failing test, and all the almost 1000 tests pass now 😃 The problem is that this method (and the previous approach) are not 100% exhaustive in figuring out which are coords that should have realized data, so a few of these warnings will be raised for those that the check misses them, but beats me how I can create a bulletproof check, given the variety of names and metadata, and differences between Zarr2 and Zarr3 (alas, most of them don't raise the warning)
|
NB As explained valeriupredoi#2 I actually think it's better to go back to #145. |
Shadow to #145
Just to preview tests for that, since CI runs here !