Skip to content

Conversation

@pp-mo
Copy link
Owner

@pp-mo pp-mo commented Feb 6, 2025

See if this works ...

Closes #90

OK this looks like a fairly big change, but it really only affects

  1. the error message construction in dataset_difference
  2. the relevant unit tests

So, I think that can safely go in v0.2 release.

@pp-mo pp-mo marked this pull request as draft February 6, 2025 17:27
@pp-mo pp-mo linked an issue Feb 6, 2025 that may be closed by this pull request
@pp-mo
Copy link
Owner Author

pp-mo commented Feb 6, 2025

So... this does work with numpy 2.2 ✔️

I can confirm that, at this time, it also does (did) still work with numpy v1.26

@pp-mo pp-mo marked this pull request as ready for review February 7, 2025 10:58
@pp-mo pp-mo changed the title Numpy2 predocs Numpy2 Feb 7, 2025
@pp-mo pp-mo changed the title Numpy2 Numpy v2 support Feb 7, 2025
@pp-mo pp-mo merged commit d6aaf03 into main Feb 7, 2025
3 checks passed
@pp-mo pp-mo mentioned this pull request Feb 7, 2025
6 tasks
@pp-mo pp-mo deleted the numpy2_predocs branch February 19, 2025 12:08
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better numpy v2 compatibility

2 participants