Merged
Conversation
cameronwhite
added a commit
that referenced
this pull request
Jul 26, 2022
This will be used for rhythm slashes, which play the current chord. The implementation from ScoreUtils::getCurrentPlayers() is reused, with performance improvements to search backward from the current position instead of from the beginning of the score
The idea will be to store rhythm slashes as just a regular staff (e.g. containing notes for all of the chord notes), which hopefully will make many operations like MIDI playback straightforward. However, they'll of course be treated differently for editing and rendering to appear as rhythm slashes With this change, any rhythm slashes in the v1.7 file result in an extra staff being added to the system, and most of the note properties from rhythm slashes are imported Some extra bookkeeping is required to update the player changes correctly when rhythm slashes appear / disappear from one system to the next. #16
The volume for the staff was being read instead, which led to an assertion failure if the staff volume wasn't set.
1aeb18d to
4272b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress on implementing rhythm slashes (#16)