Add custom system spacing#382
Merged
cameronwhite merged 2 commits intopowertab:masterfrom Jun 12, 2022
Merged
Conversation
System spacing can now be set in Preferences->General tab
Member
cameronwhite
left a comment
cameronwhite
left a comment
There was a problem hiding this comment.
This looks good, great work!
I think putting it in the global settings seems reasonable since it's very specific to the user / display being used
I just had the one formatting note mentioned in the comments
source/app/scorearea.cpp
Outdated
| void | ||
| ScoreArea::loadSystemSpacing(const SettingsManager &settings_manager, bool redraw) | ||
| { | ||
| auto settings = settings_manager.getReadHandle(); |
Member
There was a problem hiding this comment.
It looks like there's only a 2-space indent here, but it should be 4
Contributor
Author
There was a problem hiding this comment.
Got it! Should be fixed now
cameronwhite
added a commit
that referenced
this pull request
Jul 22, 2022
Any settings change (e.g. when opening a new file, the last used directory is updated in the settings) caused all open scores to be redrawn. Instead, this should only happen if the value we're interested in actually changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
System spacing can now be set in Preferences->General tab.
An arbitrary range from 0 to 100 was used.
I did this just to get my feet wet - let me know if anything should be changed or if this setting should actually be set somewhere else.
Appreciate any feedback =)
Fixes Issue(s)
#239