Skip to content

Feature/add os and version information dialog#329

Merged
cameronwhite merged 12 commits intopowertab:masterfrom
psyomn:feature/add-os-and-version-information-dialog
Apr 4, 2021
Merged

Feature/add os and version information dialog#329
cameronwhite merged 12 commits intopowertab:masterfrom
psyomn:feature/add-os-and-version-information-dialog

Conversation

@psyomn
Copy link
Copy Markdown
Contributor

@psyomn psyomn commented Mar 26, 2021

Description of Change(s)

Add version information dialog so that problems can be reported much easier.

screen

So I plan to tie in future work for logging by adding another tab where you can copy logs from this dialog to post on github. Feel free to reject these changes if you think they're superfluous -- opening right now to start a convo!

NB: I moved some code around, let me know if you agree with that too.

Fixes Issue(s)

  • N/A

(lemme know what you think and if you deem this worthwhile, I'll fix up this PR)

Copy link
Copy Markdown
Member

@cameronwhite cameronwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea - thanks for taking a look at this!
I wonder if this should somehow be merged in with the Report Bug... menu item too?

@psyomn psyomn marked this pull request as ready for review April 4, 2021 01:59
@psyomn
Copy link
Copy Markdown
Contributor Author

psyomn commented Apr 4, 2021

I wonder if this should somehow be merged in with the Report Bug... menu item too?

I'm trying to think of a nice way to represent that in the UI. Were you thinking of moving that functionality to the new dialog I created? For example an extra button?

Also the build is acting a little weird right now and OSX builds seem to not be building. I'll check again soon.

Copy link
Copy Markdown
Member

@cameronwhite cameronwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! It builds fine locally for me on macOS so I think the builds are just having some issues.

After testing out the changes I think the UI is good for now - keeping a top-level menu item to report a bug makes that more discoverable

@cameronwhite cameronwhite merged commit e5c9eaf into powertab:master Apr 4, 2021
@psyomn
Copy link
Copy Markdown
Contributor Author

psyomn commented Apr 4, 2021

Thanks! I'll get cracking on the logging I was talking about in that other thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants