Skip to content

Commit 1e5c4f9

Browse files
Kaap10potiuk
andauthored
feat(release-management): add verify-rc live checklist pane mod scaffolding and UI component (apache#2007)
* feat(release-management): add verify-rc live checklist pane mod scaffolding and UI component Set up hooks scaffolding in plugins/magpie-release-management/hooks, declare verifyRcState atom and types, implement presentational Pane component with live status badges, and add unit test suite. Refs apache#2006, apache#1497 Generated-by: Antigravity (Gemini 2.5 Pro) * fix(release-management): escape em dash in codex-hooks.json Check-family-plugins json.dumps serializer writes unicode-escaped \\u2014. Generated-by: Antigravity (Gemini 2.5 Pro) * fix(release-management): list the JVM and Nexus steps in the verify-rc pane The pane's checklist left out Steps 6b and 6c, which release-verify counts towards the verdict, so an RC with JVM artefacts had no row for a failure in either. Add them in STEP_ORDER's order. Use the sanitizer sequence from the review-findings mod: a line break in a detail could draw a second, false checklist row, and private-mode escape sequences left their text behind. Generated-by: Claude Opus 5 --------- Co-authored-by: Jarek Potiuk <[email protected]>
1 parent d8659ed commit 1e5c4f9

9 files changed

Lines changed: 1138 additions & 0 deletions

File tree

‎plugins/magpie-release-management/.claude-plugin/plugin.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,6 @@
99
"homepage": "https://magpie.apache.org/",
1010
"repository": "https://github.com/apache/magpie",
1111
"license": "Apache-2.0",
12+
"types": "./hooks/types.d.ts",
1213
"skills": "./skills"
1314
}
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
{
2+
"name": "magpie-release-management",
3+
"description": "Apache Magpie \u2014 ASF release lifecycle: plan, RC cut/sign, vote, tally, promote, announce, archive, audit.",
4+
"version": "0.9.0.dev202611041445",
5+
"author": {
6+
"name": "Apache Magpie",
7+
"url": "https://magpie.apache.org/"
8+
},
9+
"homepage": "https://magpie.apache.org/",
10+
"repository": "https://github.com/apache/magpie",
11+
"license": "Apache-2.0",
12+
"skills": "./skills",
13+
"hooks": "./hooks/codex-hooks.json"
14+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"description": "Apache Magpie \u2014 no Codex hooks. hooks.json holds Claude Code mods only.",
3+
"hooks": {}
4+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"$schema": "https://code.claude.com/schemas/hooks.json",
3+
"description": "Apache Magpie — Claude Code mod for live verification checklist in verify-rc.",
4+
"modules": [
5+
"./verify-rc-pane.ts"
6+
]
7+
}
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
// SPDX-License-Identifier: Apache-2.0
2+
//
3+
// Licensed to the Apache Software Foundation (ASF) under one
4+
// or more contributor license agreements. See the NOTICE file
5+
// distributed with this work for additional information
6+
// regarding copyright ownership. The ASF licenses this file
7+
// to you under the Apache License, Version 2.0 (the
8+
// "License"); you may not use this file except in compliance
9+
// with the License. You may obtain a copy of the License at
10+
//
11+
// http://www.apache.org/licenses/LICENSE-2.0
12+
//
13+
// Unless required by applicable law or agreed to in writing,
14+
// software distributed under the License is distributed on an
15+
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
16+
// KIND, either express or implied. See the License for the
17+
// specific language governing permissions and limitations
18+
// under the License.
19+
20+
// Self-contained ambient declaration required by strict plugin validation.
21+
// Companion TypeScript runtime definitions live in types.ts. Both type declarations
22+
// must be kept in sync when modifying the state shape.
23+
24+
declare module 'claude-code' {
25+
interface PluginState {
26+
'magpie-release-management': {
27+
verifyRcState: {
28+
rcTag: string;
29+
version: string;
30+
stagingUrl?: string | null;
31+
postTo?: string | null;
32+
overallStatus: 'running' | 'passed' | 'passed-with-warnings' | 'failed';
33+
currentStepId?: string | null;
34+
steps: Array<{
35+
id: string;
36+
label: string;
37+
status: 'pending' | 'running' | 'passed' | 'failed' | 'warning' | 'skipped';
38+
detail?: string | null;
39+
durationMs?: number | null;
40+
}>;
41+
startedAt: number;
42+
completedAt?: number | null;
43+
} | null;
44+
};
45+
}
46+
}
Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
// SPDX-License-Identifier: Apache-2.0
2+
//
3+
// Licensed to the Apache Software Foundation (ASF) under one
4+
// or more contributor license agreements. See the NOTICE file
5+
// distributed with this work for additional information
6+
// regarding copyright ownership. The ASF licenses this file
7+
// to you under the Apache License, Version 2.0 (the
8+
// "License"); you may not use this file except in compliance
9+
// with the License. You may obtain a copy of the License at
10+
//
11+
// http://www.apache.org/licenses/LICENSE-2.0
12+
//
13+
// Unless required by applicable law or agreed to in writing,
14+
// software distributed under the License is distributed on an
15+
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
16+
// KIND, either express or implied. See the License for the
17+
// specific language governing permissions and limitations
18+
// under the License.
19+
20+
// Companion ambient declaration lives in types.d.ts for Claude Code mod plugin
21+
// validation. Any property added to VerifyRcState or VerifyRcStep must be
22+
// kept in sync across both files.
23+
24+
export type VerifyStepId =
25+
| 'preflight'
26+
| 'inventory'
27+
| 'signatures'
28+
| 'checksums'
29+
| 'rat-license-headers'
30+
| 'notice-license'
31+
| 'binary-exclusion'
32+
| 'jvm-artefacts'
33+
| 'nexus-staging'
34+
| 'source-tree-integrity'
35+
| 'version-consistency'
36+
| 'reproducibility'
37+
| 'verdict';
38+
39+
export type StepStatus = 'pending' | 'running' | 'passed' | 'failed' | 'warning' | 'skipped';
40+
41+
export type OverallVerifyStatus = 'running' | 'passed' | 'passed-with-warnings' | 'failed';
42+
43+
export interface VerifyRcStep {
44+
id: VerifyStepId;
45+
label: string;
46+
status: StepStatus;
47+
detail?: string | null;
48+
durationMs?: number | null;
49+
}
50+
51+
export interface VerifyRcState {
52+
rcTag: string;
53+
version: string;
54+
stagingUrl?: string | null;
55+
postTo?: string | null;
56+
overallStatus: OverallVerifyStatus;
57+
currentStepId?: VerifyStepId | null;
58+
steps: VerifyRcStep[];
59+
startedAt: number;
60+
completedAt?: number | null;
61+
}
62+
63+
/**
64+
* Returns the canonical 13 verification steps in exact SKILL.md execution order,
65+
* all initialized in 'pending' status.
66+
*/
67+
export function createDefaultVerifySteps(): VerifyRcStep[] {
68+
return [
69+
{ id: 'preflight', label: 'Pre-flight check & config resolution', status: 'pending' },
70+
{ id: 'inventory', label: 'Staged artefacts inventory', status: 'pending' },
71+
{ id: 'signatures', label: 'GPG signatures (KEYS verification)', status: 'pending' },
72+
{ id: 'checksums', label: 'SHA512 & digest checksums', status: 'pending' },
73+
{ id: 'rat-license-headers', label: 'Apache RAT license headers', status: 'pending' },
74+
{ id: 'notice-license', label: 'NOTICE and LICENSE integrity', status: 'pending' },
75+
{ id: 'binary-exclusion', label: 'Prohibited binaries scan', status: 'pending' },
76+
{ id: 'jvm-artefacts', label: 'JVM artefact checks', status: 'pending' },
77+
{ id: 'nexus-staging', label: 'Nexus staging repository', status: 'pending' },
78+
{ id: 'source-tree-integrity', label: 'Source integrity & symlinks', status: 'pending' },
79+
{ id: 'version-consistency', label: 'Version manifest consistency', status: 'pending' },
80+
{ id: 'reproducibility', label: 'Reproducible build verification', status: 'pending' },
81+
{ id: 'verdict', label: 'Final verification verdict', status: 'pending' },
82+
];
83+
}

0 commit comments

Comments
 (0)