-
Notifications
You must be signed in to change notification settings - Fork 2
Comparing changes
Open a pull request
base repository: postgresql-cfbot/postgresql
base: cf/1608~1
head repository: postgresql-cfbot/postgresql
compare: cf/1608
- 12 commits
- 59 files changed
- 2 contributors
Commits on Apr 16, 2026
-
CREATE VARIABLE, DROP VARIABLE
Introduce simple (non transactional) implementation of basic DDL statements. Because only temporary variables are allowed, we don't need a dedicated catalog. This is the most reduced version of declared session variables implementation. Main goal is introduction of basic functionality and reducing the size of the patch to maximum. This patch is designed to be possible to move to catalog based implementation without compatibility break. Some details about different implementations of session variables https://wiki.postgresql.org/wiki/Implementation_of_declarative_catalog_session_variables
Configuration menu - View commit details
-
Copy full SHA for a1ac7f0 - Browse repository at this point
Copy the full SHA a1ac7f0View commit details -
parsing session variable fences
The session variables can be used in query only inside the variable fence. This is special syntax VARIABLE(varname), that eliminates a risk of collision between variable and column identifier. The session variables cannot be used as parameters of CALL or EXECUTE commands. These commands evaluates arguments by direct call of expression executor, and direct access to session variables from expression executor will be implemented later (in next step)
Configuration menu - View commit details
-
Copy full SHA for ba7aa5e - Browse repository at this point
Copy the full SHA ba7aa5eView commit details -
collect session variables used in plan and assign paramid
In the plan stage we need to collect used session variables. On the order of this list, the param nodes gets paramid (fix_param_node). This number is used (later) as index to buffer of values of the used session variables. The buffer is prepared and filled by executor. Some unsupported optimizations are disabled: * parallel execution * simple expression execution in PL/pgSQL * SQL functions inlining Before execution of query with session variables we need to collect used session variables. This list is used for loading variables to executed query. plan
Configuration menu - View commit details
-
Copy full SHA for 2d885f1 - Browse repository at this point
Copy the full SHA 2d885f1View commit details -
fill an auxiliary buffer with values of session variables used in query
and locks variables used in query. Now we can read the content of any session variable. Direct reading from expression executor is not allowed, so we cannot to use session variables inside CALL or EXECUTE commands (can be supported with direct access to session variables (from expression executor) - postponed). Using session variables blocks parallel query execution. It is not technical problem (it just needs a serialization/deserialization of es_session_varibles buffer), but it increases a size of patch (and then it is postponed).
Configuration menu - View commit details
-
Copy full SHA for 1f5fa44 - Browse repository at this point
Copy the full SHA 1f5fa44View commit details -
allows to store result of the query to session variable Check correct format of result - one column, one row.
Configuration menu - View commit details
-
Copy full SHA for 73bef15 - Browse repository at this point
Copy the full SHA 73bef15View commit details -
LET command - assign a result of expression to the session variable
The value is assigned to session variables usually by SET command. Unfortunately there are two reasons why SET should not be used for this purpose in Postgres. 1. Using a_expr inside generic_set ram rule produces reduce conflicts, so it needs total reimplementation of related gram rules. 2. SET is no plan command - so it doesn't support usage of parameters. 3. Excepting implementation issues, there is fact, so if we use SET command for assigning values to session variables, then there can be collisions between session variables and GUC, and then we need some concepts, how these collisions should be solved, or how to protect self against these collisions. With the dedicated command, the collisions between GUC and session variables are not possible. The command LET is executed as usual query execution. The result is stored to the target session variable (resultVariable) by using VariableDestReceiver. Implementations of EXPLAIN LET and PREPARE LET statements are not supported now. Postponed to next step due reducing patch size.
Configuration menu - View commit details
-
Copy full SHA for cb3fd2d - Browse repository at this point
Copy the full SHA cb3fd2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37a2f87 - Browse repository at this point
Copy the full SHA 37a2f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d046f2 - Browse repository at this point
Copy the full SHA 1d046f2View commit details -
use names of currently used temp variables for tab complete of DROP V…
…ARIABLE, LET and VARIABLE()
Configuration menu - View commit details
-
Copy full SHA for 9540e51 - Browse repository at this point
Copy the full SHA 9540e51View commit details -
transactional DDL - CREATE VARIABLE, DROP VARIABLE
Generally PostgreSQL DDL statements are transactional. We can implement transactional behave for ( CREATE | DROP ) VARIABLE too. Implementation is almost simple. DROP just set dropped_lxid, CREATE set created_lxid and moves previous entry of related sessionvars hashtab to stack. At the end of transaction for commit we just clean this stack. For rollback we do copy the bootom value from the stack and again clean stack.
Configuration menu - View commit details
-
Copy full SHA for b4f73d8 - Browse repository at this point
Copy the full SHA b4f73d8View commit details -
subtransaction support for session variables DDL (CREATE, DROP)
If we support transactional DDL for CREATE, DROP session variables, we should to support subtransactions too. Implementation is simple. Any value has two new flags: created_subid and dropped_subid. At the subtransaction end for rollback we clean entries from the stack related to subtransactions. When commit we update created_subid and dropped_subid for parent subtransaction.
Configuration menu - View commit details
-
Copy full SHA for 271fe46 - Browse repository at this point
Copy the full SHA 271fe46View commit details -
[CF 1608] v20260403 - declarative session variables, LET command
This branch was automatically generated by a robot using patches from an email thread registered at: https://commitfest.postgresql.org/patch/1608 The branch will be overwritten each time a new patch version is posted to the thread, and also periodically to check for bitrot caused by changes on the master branch. Patch(es): https://www.postgresql.org/message-id/CAFj8pRBH629MNqris2U4wyocNd0na5wv6czeUHRoTKYEH90-yA@mail.gmail.com Author(s): Pavel Stehule
Commitfest Bot committedApr 16, 2026 Configuration menu - View commit details
-
Copy full SHA for 1b86585 - Browse repository at this point
Copy the full SHA 1b86585View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff cf/1608~1...cf/1608