Fix an issue where messages without text property are shown as undefined [plugin-name]#46
Merged
ai merged 2 commits intopostcss:masterfrom Dec 30, 2018
Merged
Conversation
Author
|
@davidtheclark ping? |
Author
|
@davidtheclark Hi, do you have any thoughts on this PR? |
Contributor
|
This repository needs a new maintainer. I will add a message to the README asking for help. @ai if you'd like to use your social media following to spark interest, maybe that would help find someone. |
Member
|
I will take maintainability of the project. @davidtheclark please give me npm rights. |
Contributor
|
Ok, @ai: added you as an npm owner. |
Member
|
Thanks. Released in 6.0.1 |
Author
|
@davidtheclark @ai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the postcss API document, required properties of
Messageare onlytypeandplugin.postcss-import, for example, pushes messages withouttextproperty.postcss-reporter, however, assumes each message hastext, causingundefinedto be shown as a message body for such messages.Due to this issue, when
postcss-importandpostcss-calcare used in this order, the same number ofundefinedmessages as that of@importrules existing in CSS files to be concatinated appear in a console, which is quite annoying. You can get code to reproduce this issue at https://github.com/nodaguti/postcss-calc-warning.This PR fixes the issue by filtering out messages that don't have
textproperty in the formatter.