change req to resolve based on file path rather than directory#231
Merged
ai merged 1 commit intopostcss:mainfrom Feb 11, 2022
Merged
change req to resolve based on file path rather than directory#231ai merged 1 commit intopostcss:mainfrom
req to resolve based on file path rather than directory#231ai merged 1 commit intopostcss:mainfrom
Conversation
We previously had a fabricated file name (`_`) to forcefully resolve a given directory path to a file path, so `createRequire` would be happy. Since we now pass the file path every time, we no longer need this. In future, if we need to `req` a directory, we should resolve the path at the call-site rather than inside `req`.
mojavelinux
added a commit
to mojavelinux/postcss-load-config
that referenced
this pull request
Feb 12, 2022
2 tasks
ai
pushed a commit
that referenced
this pull request
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously had a fabricated file name (
_) to forcefully resolve agiven directory path to a file path, so
createRequirewould be happy.Since we now pass the file path every time, we no longer need this.
In future, if we need to
reqa directory, we should resolve the pathat the call-site rather than inside
req.TypeSemVerIssuesFixes the problems mentioned in #229.
@ai we really should add some tests for the various ways things can be resolved. could you help with that some time as i dont fully follow what is tested where yet.
basically some tests (if they dont exist already) to ensure we can have various types of paths to plugins (relative, absolute, etc).