Merged
Conversation
Member
|
This is my favorite type of PRs! |
Member
|
But we need to support old Node.js 10 |
Contributor
Author
|
hmm, the package we were depending on pretty much does this same code, so maybe we already regressed when we introduced it? (supporting node 10) looking at the node docs, it looks like 10.x has |
Member
|
Breaking changes is not worth for 2-3 dependencies reduction |
Contributor
Author
|
its ok i've figured it out, we were using an older version of the dependency. ill see if i can update the code |
43081j
force-pushed
the
drop-import-cwd
branch
from
685d5d7 to
e371af7
Compare
Contributor
Author
|
@ai can you trigger CI? this seems to work locally on node 10 |
Member
|
Thanks. Released in 3.1.1. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ai up to you if you want this or not ofc.
basically we introduced import-cwd at some point which is arguably fairly redundant since we can just use the built in node functions for this directly. personally don't see the point in these one-liner packages.
by dropping it, you can reduce the dependencies tree by at least 2-3 packages (surprisingly for something so simple).
let me know if you agree
TypeSemVerChecklist