Add support for glob matching when watching dir-dependency#391
Merged
RyanZim merged 1 commit intopostcss:masterfrom Sep 23, 2021
Merged
Add support for glob matching when watching dir-dependency#391RyanZim merged 1 commit intopostcss:masterfrom
RyanZim merged 1 commit intopostcss:masterfrom
Conversation
This extends postcss#383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
Collaborator
|
I'm not closed to this idea; are there any plugins that use this |
Member
Collaborator
|
Ah, wasn't up on the standards changes, in that case, LGTM. |
RyanZim
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends #383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified.
In my test example the output should only be triggered when files matching the
glob: '**/*.css'are modified, but not when theunrelated.mdfile is modified.A real world example where I thought watching a whole directory without applying the glob could be problematic, would be a full stack project where tailwind checks backend templates by file type for purging:
In this case I really only want to trigger rebuilds when changing one of the listed file types.
Chokidar supports all this out of the box btw.
Let me know what you think and thanks for the great project!
Cheers!