Error when using unsupported PostCSS version (#361)#362
Merged
RyanZim merged 1 commit intopostcss:masterfrom Dec 8, 2020
Merged
Error when using unsupported PostCSS version (#361)#362RyanZim merged 1 commit intopostcss:masterfrom
RyanZim merged 1 commit intopostcss:masterfrom
Conversation
1 similar comment
ai
reviewed
Dec 6, 2020
Member
|
@RyanZim this PR is ready to merge. My |
Contributor
Author
|
I tried to find a good solution to the auto-discovery of the package manager but to no avail. Could keep looking for a solution for a later PR though of the feature is really needed. |
Collaborator
|
KISS; no need for any fancy auto-detection. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
postcssversion check @ai talked about. Changed the wording a bit and used the built-inerrorfunction.As for testing this functionality, not going to lie. I couldn't get this error to throw ones, even did the steps mentioned in the issue (#361) by using
npm linkto this version and installing plugins that usePostCSS 7and it builds the CSS file and didn't throw a single error.Seems like this error might be thrown very rarely? But I do hope it helps in the long run. 🙂