Skip to content

Fix map file path creation#286

Merged
RyanZim merged 4 commits intopostcss:masterfrom
bcomnes:fix-external-map-bug
Jul 8, 2019
Merged

Fix map file path creation#286
RyanZim merged 4 commits intopostcss:masterfrom
bcomnes:fix-external-map-bug

Conversation

@bcomnes
Copy link
Copy Markdown
Contributor

@bcomnes bcomnes commented Jul 6, 2019

Closes #283

I wrote a failing test and then implemented a similar version that works.

@bcomnes bcomnes changed the title Add failing test for external map file path creation Fix map file path creation Jul 6, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 6, 2019

Coverage Status

Coverage increased (+0.5%) to 75.839% when pulling ee41093 on bcomnes:fix-external-map-bug into f1c7352 on postcss:master.

@RyanZim RyanZim merged commit 0de7ccf into postcss:master Jul 8, 2019
@RyanZim
Copy link
Copy Markdown
Collaborator

RyanZim commented Jul 8, 2019

Released in v6.1.3 🎉 Sorry for the slow merge, was on vacation.

@bcomnes bcomnes deleted the fix-external-map-bug branch July 8, 2019 18:00
@bcomnes
Copy link
Copy Markdown
Contributor Author

bcomnes commented Jul 8, 2019

Woo! Slow merge? That was fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Having a .css in the directory path breaks external source map paths

3 participants