Fix missing offset in Node#positionInside, Node#positionBy and Node#rangeBy#2033
Merged
Conversation
- The `opts` argument to `Node#error` is currently omissible, but we'll assign a default value just in case.
mizdra
force-pushed
the
fix-missing-offset
branch
from
March 22, 2025 12:15
1778f8a to
b5aa0cb
Compare
mizdra
marked this pull request as ready for review
March 22, 2025 12:15
mizdra
marked this pull request as draft
March 22, 2025 12:16
mizdra
commented
Mar 22, 2025
mizdra
marked this pull request as ready for review
March 22, 2025 12:20
Member
|
CI is still falling. Maybe it is an issue after the merge? Can you look? |
Contributor
Author
|
Thanks for reviewing! I fixed the conflict resolution mistakes. |
ai
pushed a commit
that referenced
this pull request
Jun 27, 2026
positionBy()'s default branch returned this.source.start verbatim, so for custom syntaxes whose source.start lacks an offset (e.g. postcss-html) it returned a position without offset, violating the Position type which declares offset as required. rangeBy()/positionInside() were normalized to always compute offset via sourceOffset() (#2033, issue #2029) but positionBy() was left behind. Mirror the rangeBy() pattern. Co-authored-by: oss69U-prep <prep@local> Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2029
base on: #2031