Skip to content

Pins nanoid to ^3.3.8#1992

Merged
ai merged 2 commits intopostcss:mainfrom
fsmeier:patch-1
Dec 13, 2024
Merged

Pins nanoid to ^3.3.8#1992
ai merged 2 commits intopostcss:mainfrom
fsmeier:patch-1

Conversation

@fsmeier
Copy link
Copy Markdown
Contributor

@fsmeier fsmeier commented Dec 13, 2024

Infinite loop in nanoid <3.3.8
See GHSA-mwcw-c2x4-8c55

@fsmeier
Copy link
Copy Markdown
Contributor Author

fsmeier commented Dec 13, 2024

Heyhey @ai ,
can you please have a look here and also deploy a new tag afterwards?
Its already updated by you 3 days ago (#1989) but it would be cool to tag it to resolve the audit messages.

All the best,
Florian

@ai
Copy link
Copy Markdown
Member

ai commented Dec 13, 2024

  1. You forgot to update lock file
  2. Why do you need to release it? ^ means any version bigger.

@fsmeier
Copy link
Copy Markdown
Contributor Author

fsmeier commented Dec 13, 2024

Wow, you react very fast :D thank you!

  1. fixed - i thought it was not needed since it was already updated within the lock file; but i was wrong, one line was missing.
  2. Currently its only ^3.3.7 which somehow triggers the npm audit for me.

@fsmeier
Copy link
Copy Markdown
Contributor Author

fsmeier commented Dec 13, 2024

@ai
Copy link
Copy Markdown
Member

ai commented Dec 13, 2024

npm audit checks not postxss, but your node_modules.

The issue is in your node_modules.

You need to update nested dependencies (there are many tools, I prefer just using pnpm update, but for npm you can run npm audit --fix).

@ai ai merged commit 4493eed into postcss:main Dec 13, 2024
@ai
Copy link
Copy Markdown
Member

ai commented Dec 13, 2024

I am going to merge it to put your name in to the project history. But I am not going plan to release it since we don’t need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants