reduce calls to Node.prototype.toString()

romainmenke · romainmenke · commit 492f47410427 · 2023-07-02T11:37:12.000+02:00
diff --git a/lib/node.js b/lib/node.js
@@ -229,8 +229,8 @@ class Node {
     return fixed
   }
 
-  positionInside(index) {
-    let string = this.toString()
+  positionInside(index, stringRepresentation) {
+    let string = stringRepresentation || this.toString()
     let column = this.source.start.column
     let line = this.source.start.line
 
@@ -246,13 +246,14 @@ class Node {
     return { line, column }
   }
 
-  positionBy(opts) {
+  positionBy(opts, stringRepresentation) {
     let pos = this.source.start
     if (opts.index) {
-      pos = this.positionInside(opts.index)
+      pos = this.positionInside(opts.index, stringRepresentation)
     } else if (opts.word) {
-      let index = this.toString().indexOf(opts.word)
-      if (index !== -1) pos = this.positionInside(index)
+      stringRepresentation = this.toString()
+      let index = stringRepresentation.indexOf(opts.word)
+      if (index !== -1) pos = this.positionInside(index, stringRepresentation)
     }
     return pos
   }
@@ -264,19 +265,20 @@ class Node {
     }
     let end = this.source.end
       ? {
-          line: this.source.end.line,
-          column: this.source.end.column + 1
-        }
+        line: this.source.end.line,
+        column: this.source.end.column + 1
+      }
       : {
-          line: start.line,
-          column: start.column + 1
-        }
+        line: start.line,
+        column: start.column + 1
+      }
 
     if (opts.word) {
-      let index = this.toString().indexOf(opts.word)
+      let stringRepresentation = this.toString()
+      let index = stringRepresentation.indexOf(opts.word)
       if (index !== -1) {
-        start = this.positionInside(index)
-        end = this.positionInside(index + opts.word.length)
+        start = this.positionInside(index, stringRepresentation)
+        end = this.positionInside(index + opts.word.length, stringRepresentation)
       }
     } else {
       if (opts.start) {
