feat: Disable server-side bookmarking for py-shiny#206
Merged
karangattu merged 1 commit intomainfrom Apr 8, 2025
Merged
Conversation
Contributor
|
Verified that enabling server side bookmarking for an app in shinylive throws a error notification - When using url bookmarking, the query params still do not update in the url address bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: posit-dev/py-shiny#1914
Related: posit-dev/py-shiny#1956
Q: Should R shiny also have it's server-side bookmarking disabled?
Q: This might get the app to have bookmarking... but what about forwarding any query string values to the parent frame for shinylive.io? If the same answer as r-shiny is... not at the top of the priority queue... then we can wait until later!
TODO: