chore(render.display): Improve error message#1020
Merged
Conversation
schloerke
approved these changes
Jan 19, 2024
Collaborator
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
Thank you for the suggestion within the PR!
I believe it is possible that render.display is used within Core. So I altered the phrasing as you suggested.
schloerke
added a commit
that referenced
this pull request
Jan 19, 2024
* main: (26 commits) api!: Merge RendererBase class into Renderer (#1032) chore(render.display): Improve error message (#1020) `express.ui.page_opts(title = ...)` now always generates a header (#1016) api!: `Renderer.auto_output_ui()` drops `id` arg. Make `RendererBase.output_id` a non-namespaced value. (#1030) fix(page_sidebar): Add semicolon to end style declaration (#1027) chore: Remove experimental from app (#1028) chore: Expose `render.renderer.RendererBaseT` and do not require `| None` when defining Renderer types (#1026) bug: Restore legacy renderers while packages transition (#1023) Update deploy test apps to use render.code Update changelog Provide useful message in Express when `input` was not imported (#994) Calculate coordinate mapping after drawing figure (#999) Remove `express.ui.output_*` functions, add `shiny.express.render` (#1018) fix: Do not allow for renderer's to be given to reactive effects (#1017) Truncate the requirements.txt file before deploys (#998) Update changelog Fixes for flake8 (#1012) Pin starlette version below 0.35 (#1009) Remove shiny express warning Cause RecallContextManagers to run when used without `with` (#992) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the error thrown by
@render.displaywhen the decorated function has a return value fromto
Notes and Questions
Is
@render.displayintended only for Shiny Express? (If yes, this does speak to havingshiny.express.renderand for not includingrender.displayinshiny.)@schloerke described
@render.displayas follows on Slack:If
render.displayis intended for Shiny Core as well then we could fall back to "Instead, @render.display dynamically renders every printable line within the function body" rather than naming Shiny Express. This phrasing is technically more precise but still not quite actionable for someone just starting with Shiny or Express.