return defauldt Provider for Share_Type_Remote_Group#16
return defauldt Provider for Share_Type_Remote_Group#16navid-shokri merged 1 commit intoaccept-ocm-to-groupsfrom
Conversation
yasharpm
left a comment
yasharpm
left a comment
There was a problem hiding this comment.
This is a dilemma.
FederatedShareProvider does not support SHARE_TYPE_REMOTE_GROUP. Even though the tests might pass, we have to make sure that this change does not break any functionality of the OC. For example, in another section of code, all shares for all share types might be queried. In such an instance, if there is a remote user share, the OC might show it twice because it received it once from the FederatedProvider for SHARE_TYPE_REMOTE and another type from the same object but for the SHARE_TYPE_REMOTE_GROUP.
A cleaner approach to solve this issue, I believe, is to add a function to IManager to return all the supported share types. And then change the behavior of apps/dav/lib/Connector/Sabre/SharesPlugin.php to query the supported share types from the IManager instead of using a hard coded list. But this will further complicate the chance of our PR into OC to be accepted.
The current fix is quick and sample (if it works) but logically inaccurate. While my counter proposal might complicate the PR process but more elegant.
I think the next course of action is:
- Make sure the suggested test does not result in bugs in OC
- Consult @michielbdejong and @thepeak99 to make a decision on the elegance vs PR merge difficulty.
2 participants
set a default share provider for SHARE_TYPE_REMOTE_GROUP
Related Issue
pondersource/oc-opencloudmesh#19
Motivation and Context
federated groups and opencloudmeshapplication