Skip to content

Fix PHP notice in walk() methods since WP 5.3#415

Merged
Chouby merged 3 commits intomasterfrom
walkers
Oct 16, 2019
Merged

Fix PHP notice in walk() methods since WP 5.3#415
Chouby merged 3 commits intomasterfrom
walkers

Conversation

@Chouby
Copy link
Contributor

@Chouby Chouby commented Oct 15, 2019

Adapt the methods signature to WP 5.3 in a backward compatible way
(Polylang < 2.7).
Add a notice if the methods are called using the old way without
$max_depth parameter.
Adapt all methods calls.
@Chouby Chouby added the WP 5.3 label Oct 15, 2019
@Chouby Chouby added this to the 2.7 milestone Oct 15, 2019
@Chouby Chouby merged commit 125bd94 into master Oct 16, 2019
@Chouby Chouby deleted the walkers branch October 16, 2019 14:10
@Chouby Chouby modified the milestones: 2.7, 2.6.x Nov 14, 2019
@Chouby Chouby mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP Warning: Declaration of PLL_Walker_Dropdown::walk

2 participants

Comments