fix(ui): pDropdown trigger closes on 2nd click

polonel · polonel · commit e614ed61a527 · 2022-07-10T20:16:29.000-04:00
diff --git a/src/client/components/PDropdown/index.jsx b/src/client/components/PDropdown/index.jsx
@@ -18,6 +18,7 @@ import clsx from 'clsx'
 
 class PDropDown extends React.Component {
   dropRef = createRef()
+  pTriggerRef = null
 
   constructor (props) {
     super(props)
@@ -28,7 +29,7 @@ class PDropDown extends React.Component {
 
   hideDropdownOnMouseUp (e) {
     if (this.dropRef.current) {
-      if (!this.dropRef.current.contains(e.target)) {
+      if (!this.dropRef.current.contains(e.target) && !this.pTriggerRef.contains(e.target)) {
         document.removeEventListener('mouseup', this.hideDropdownOnMouseUp)
         this.dropRef.current.classList.remove('pDropOpen')
       }
@@ -48,6 +49,8 @@ class PDropDown extends React.Component {
       return true
     }
 
+    this.pTriggerRef = pTrigger
+
     if (this.dropRef.current) {
       const ref = this.dropRef.current
       if (ref.classList.contains('pDropOpen')) {
diff --git a/src/public/js/modules/helpers.js b/src/public/js/modules/helpers.js
@@ -1172,11 +1172,9 @@ define([
   }
 
   helpers.hideAllpDropDowns = function () {
-    $('[data-notifications]').each(function () {
-      var drop = $('#' + $(this).attr('data-notifications'))
-      if (drop.hasClass('pDropOpen')) {
-        drop.removeClass('pDropOpen')
-      }
+    $('.p-dropdown').each(function () {
+      const $drop = $(this)
+      if ($drop.hasClass('pDropOpen')) $drop.removeClass('pDropOpen')
     })
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1172,11 +1172,9 @@ define([`
`1172`	`1172`	`}`
`1173`	`1173`
`1174`	`1174`	`helpers.hideAllpDropDowns = function () {`
`1175`		`- $('[data-notifications]').each(function () {`
`1176`		`- var drop = $('#' + $(this).attr('data-notifications'))`
`1177`		`- if (drop.hasClass('pDropOpen')) {`
`1178`		`- drop.removeClass('pDropOpen')`
`1179`		`- }`
	`1175`	`+ $('.p-dropdown').each(function () {`
	`1176`	`+ const $drop = $(this)`
	`1177`	`+ if ($drop.hasClass('pDropOpen')) $drop.removeClass('pDropOpen')`
`1180`	`1178`	`})`
`1181`	`1179`	`}`
`1182`	`1180`