fix(dashboard): fails to load if show overdue tickets is disabled #552

polonel · polonel · commit afd9caf73eaf · 2022-08-20T04:30:31.000-04:00
diff --git a/src/client/reducers/dashboardReducer.js b/src/client/reducers/dashboardReducer.js
@@ -116,6 +116,10 @@ const reducer = handleActions(
     },
 
     [FETCH_DASHBOARD_OVERDUE_TICKETS.SUCCESS]: (state, action) => {
+      if (action.response.success && action.response.error) {
+        return { ...state, loadingOverdueTickets: false, overdueTickets: initialState.overdueTickets }
+      }
+
       return {
         ...state,
         loadingOverdueTickets: false,
diff --git a/src/controllers/api/v1/tickets.js b/src/controllers/api/v1/tickets.js
@@ -1958,7 +1958,7 @@ apiTickets.getOverdue = function (req, res) {
       ],
       function (err, overdueTickets) {
         if (err) return res.status(400).json({ success: false, error: err.message })
-
+        if (!overdueTickets) overdueTickets = []
         return res.json({ success: true, tickets: overdueTickets })
       }
     )

Original file line number	Diff line number	Diff line change
`@@ -1958,7 +1958,7 @@ apiTickets.getOverdue = function (req, res) {`
`1958`	`1958`	`],`
`1959`	`1959`	`function (err, overdueTickets) {`
`1960`	`1960`	`if (err) return res.status(400).json({ success: false, error: err.message })`
`1961`		`-`
	`1961`	`+ if (!overdueTickets) overdueTickets = []`
`1962`	`1962`	`return res.json({ success: true, tickets: overdueTickets })`
`1963`	`1963`	`}`
`1964`	`1964`	`)`