fix(mailer): crash if no email recipients were defined

polonel · polonel · commit 6184e68e8968 · 2023-06-10T13:08:23.000-04:00
diff --git a/src/emitter/events/event_ticket_created.js b/src/emitter/events/event_ticket_created.js
@@ -88,6 +88,11 @@ const parseMemberEmails = async ticket => {
 }
 
 const sendMail = async (ticket, emails, baseUrl, betaEnabled) => {
+  if (emails.length < 1) {
+    logger.warn('[CreateTicketEvent::SendMail] - No recipients defined for sendMail')
+    return
+  }
+
   let email = null
 
   if (betaEnabled) {
@@ -135,7 +140,10 @@ const sendMail = async (ticket, emails, baseUrl, betaEnabled) => {
     }
 
     Mailer.sendMail(mailOptions, function (err) {
-      if (err) throw err
+      if (err) {
+        logger.error(err)
+        throw err
+      }
 
       logger.debug(`Sent [${emails.length}] emails.`)
     })
