Skip to content

Commit f6f4507

Browse files
committed
test(podman): explain why each remaining e2e binary is excluded
Give every remaining podmanE2eFollowUpBinaries entry its own reason, and mark the five that the wrapper-based Podman lane still runs (driver_config_volume, local_driver_token_restart, podman_corporate_proxy, podman_gateway_start, provider_token_exchange) so it is clear they are covered there until tmachine provides what they need. Contributes to NVIDIA#3712. Signed-off-by: politerealism <[email protected]>
1 parent fa76272 commit f6f4507

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

‎tests/artifacts.nix‎

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,17 +96,25 @@ let
9696
output = "artifacts/test-archives/${muslToolchain.target}/provider-refresh-keycloak-tests.tar";
9797
};
9898

99-
# Follow-up: binaries that do not yet run in the rootless tmachine guest. They
100-
# need wrapper-owned managed-gateway controls (restart, configuration), SPIFFE
101-
# fixtures, the caller driver-config setting, or guest tools. The corporate
102-
# proxy and gateway-start binaries self-skip without wrapper-owned gateway
103-
# metadata, so exclude them rather than report false passes.
99+
# Follow-up: binaries that do not yet run in the rootless tmachine guest. Each
100+
# entry says what it needs. Entries marked "wrapper lane" still run in the
101+
# wrapper-based Podman lane (`mise run e2e:podman:ci`), so they are covered
102+
# there until tmachine provides what they need.
104103
podmanE2eFollowUpBinaries = [
104+
# Needs the caller driver-config settings (`allow_driver_config`,
105+
# `enable_bind_mounts`), which the tmachine gateway does not enable. Wrapper
106+
# lane.
105107
"driver_config_volume"
108+
# The next three self-skip without wrapper-owned gateway metadata (restart
109+
# and configuration control), so exclude them rather than report false
110+
# passes. Wrapper lane.
106111
"local_driver_token_restart"
107112
"podman_corporate_proxy"
108113
"podman_gateway_start"
114+
# Its move to conformance is deferred until the isolation work in #4120; see
115+
# #4246.
109116
"provider_auto_create"
117+
# Needs the SPIFFE fixtures that the wrapper sets up. Wrapper lane.
110118
"provider_token_exchange"
111119
# One test times out reaching support-container IPs from the sandbox in the
112120
# rootless guest; the other tests in the binary pass. Nextest archive

0 commit comments

Comments
 (0)