Skip to content

Commit 0b6637b

Browse files
committed
docs(podman): record why the e2e-podman archive runs rootless only
Address the rootless/rootful-scope acceptance criterion in NVIDIA#3712: record why the e2e-podman archive runs rootless-only in branch CI (unlike driver-podman, which runs both), and point at the decision and its reasoning on NVIDIA#4163 and NVIDIA#3712. - podman_host_gateway was checked directly rather than assumed: the outer container's host-gateway alias uses Podman's own native "host-gateway" value (resolved identically in both modes), and the supervisor-side resolution defaults to a hardcoded 127.0.0.1 on Linux regardless of rootful/rootless. No real coverage gap there. - podman_resource_limits is the one target confirmed to be privilege sensitive: it reads real cgroup v2 state, and rootless cgroup delegation is the harder, already-covered case. Rootful is unverified for that target. - CI.md and tests/artifacts.nix say plainly that a rootful leg would mean running the whole archive rootful, not just the one target that needs it -- nextest archive filters select whole binaries -- and that this was judged not worth it for one target (see NVIDIA#4163). Signed-off-by: politerealism <[email protected]>
1 parent bddbe7d commit 0b6637b

2 files changed

Lines changed: 33 additions & 0 deletions

File tree

‎CI.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,12 @@ naming any selected manual-only benchmarks separately, so a narrow run cannot
156156
be mistaken for full Podman coverage. See `nix run .#podman-e2e-coverage-summary`
157157
in TESTING.md.
158158

159+
The `driver-podman` testsuite runs both rootful and rootless Fedora Podman;
160+
`e2e-podman` runs rootless only, by decision: rootful Podman is covered by
161+
conformance, `driver-podman`, `oci-image` and `provider-refresh`, and the
162+
reasoning is recorded on #4163 and #3712. Nextest archive filters select whole
163+
binaries, so a rootful leg would mean running this entire archive rootful.
164+
159165
Three opt-in labels enable the long-running E2E suites:
160166

161167
- `test:e2e` runs the Docker, rootless Podman, Kubernetes, and VM E2E suites

‎tests/artifacts.nix‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,33 @@ let
256256
target = muslToolchain.target;
257257
output = "artifacts/test-archives/${muslToolchain.target}/openshell-podman-tests.tar";
258258
};
259+
# Runs rootless-only in branch CI today (see .github/workflows/branch-e2e.yml's
260+
# driver-specific-integration matrix), unlike podmanDriverArchive above, which
261+
# runs both rootful and rootless. Rootful Podman is covered by conformance,
262+
# driver-podman, oci-image and provider-refresh, which run both modes; the
263+
# decision to keep this archive rootless-only, and the reasoning, are recorded
264+
# on #4163 and #3712. What follows records what was checked about the
265+
# privilege-sensitive targets.
266+
#
267+
# podman_host_gateway was checked specifically (host.openshell.internal
268+
# resolution plausibly depends on the rootless pasta/slirp4netns vs. rootful
269+
# netavark/CNI network backend) and confirmed NOT privilege-sensitive: the
270+
# outer container's /etc/hosts entry uses Podman's own native "host-gateway"
271+
# alias value (container.rs), which Podman resolves identically in both
272+
# modes, and the supervisor-side resolution defaults to a hardcoded
273+
# 127.0.0.1 on Linux regardless of rootful/rootless
274+
# (PodmanComputeConfig::resolved_host_gateway_ip in config.rs). No rootful
275+
# coverage gap here.
276+
#
277+
# The one target confirmed so far to be privilege-sensitive is
278+
# podman_resource_limits, which reads real
279+
# cgroup v2 state from inside the sandbox: rootless cgroup delegation
280+
# depends on systemd-user `Delegate=` and can silently no-op if
281+
# misconfigured, making rootless the harder, higher-risk case -- already
282+
# covered here. Rootful is the lower-risk, currently-unverified path for
283+
# that one target. Since nextest archive filters select whole binaries,
284+
# covering it would mean running this entire archive rootful too, which was
285+
# judged not worth it for one target (see #4163).
259286
podmanE2eArchive = mkTestArchive {
260287
name = "podman-e2e";
261288
workspacePath = "e2e/rust";

0 commit comments

Comments
 (0)