Skip to content

Finny init - #2

Merged
Jaiminp007 merged 2 commits into
devfrom
finny-init
Feb 27, 2026
Merged

Jaiminp007 merged 2 commits into
devfrom
finny-init

Conversation

@Nisarg38

Copy link
Copy Markdown
Collaborator

What does this PR do?

Please provide a description of the issue (if there is one), the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the pr.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

@vercel

vercel Bot commented Feb 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finny Error Error Feb 22, 2026 5:08pm

@github-actions

Copy link
Copy Markdown

Hey! Your PR title Finny init doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@Jaiminp007
Jaiminp007 merged this pull request into dev Feb 27, 2026
4 of 10 checks passed
Jaiminp007 pushed a commit that referenced this pull request May 2, 2026
Fixes all 17 Copilot comments:

Telemetry opt-out (#1, #2, #3, #9, #16):
- tracker.ts now reads FINNY_TELEMETRY=0 / OPENCODE_TELEMETRY=0 at module
  load, so the opt-out applies in every entrypoint (TUI worker, server,
  CLI), not just the bootstrap path.
- Email dialog auto-prompt and /subscribe slash command also gated on
  Analytics.isEnabled() — email POST goes to the same Convex deployment.

Tracker correctness (#5, #14, #17):
- drain() now also waits for the DeviceProfile.userId() resolution promise,
  not just the post-send promise.
- worker rpc.shutdown() and main-thread thread.ts both call
  Analytics.drain() before tearing down — neither beforeExit nor SIGTERM
  fire on worker.terminate() / process.exit(0).
- beforeExit handler runs at most once per process, preventing an infinite
  drain loop when a hung telemetry request later resolves and re-empties
  the loop.

Privacy (#10, #11, #12):
- Drop process.argv from tui.worker.booted (could include --prompt text
  and project paths).
- error.surfaced now sends only error.name; error messages frequently
  embed user prompt content and local file paths.
- Don't persist the submitted email address to local KV (no reader, just
  unnecessary PII retention).

Email dialog state machine (#4, #6, #8):
- Wait for kv.ready before evaluating the prompt gate so we don't re-show
  the dialog to users who already submitted/skipped.
- Conditional dismiss handler — only marks "skipped" when no terminal
  status has been set, so a successful submit isn't overwritten by the
  dismiss callback that fires on dialog.clear() and isn't suppressed by
  another dialog replacing this one.

Server-side validation (#15):
- subscribe mutation now rejects empty / oversized / regex-failing emails
  with a ConvexError, so the public Convex client can't bypass the TUI
  regex.

Command coverage (#13):
- Hook Analytics.track() in DialogCommand.trigger() instead of the bus
  event handler. trigger() is the central activation point for palette,
  slash, keybind, plugin, and bus paths — single hook, full coverage,
  no double-counting.

Comment wording (#7):
- bootstrap.ts: "opt-in by default" → "enabled by default" (correct
  description of opt-out semantics).

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Jaiminp007 pushed a commit that referenced this pull request May 3, 2026
#1 Always return JSON from algorithm-list. The empty-state branch
   previously returned a plain English string while the populated
   branch returned JSON; now both branches return the same shape so
   any caller can parse the output uniformly.

#2 Normalize capacity / remaining to (number | null) everywhere.
   The structured body and the metadata field both use null for
   unlimited tiers — no more Number.POSITIVE_INFINITY in metadata
   silently coercing to null when serialized for logs/telemetry.

#3 Tests for buildAlgorithmListPayload — extracted as a pure helper
   so the dedupe-by-name, latest-version-wins, capacity reporting,
   and JSON-roundtrip behavior can be exercised without spinning up
   Convex or the Plan service.

#4 Tests for countUniqueAlgorithms — the cap-check helper extracted
   from algorithm-save. Covers the orphan-row scenario (duplicate
   names not consuming extra cap slots) and the at-cap boundary
   condition that blocks new saves.

This branch had an error being deployed

1 failed deployment
Preview — 24196044 Deployed Feb 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants