You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: Relationship Field Taxonomy Sync now works correctly and presents as checkbox. User Interface for taxonomies using this feature should be hidden in taxonomy Admin UI settings to avoid confusion, as changes relationship field will update core taxonomy, but core taxonomy user interfaces will not update relationship field. @pdclark
PR checklist
I have tested my own code to confirm it works as I intended.
Enriched the 'pick' Class
A new 'type' attribute was added to the 'pick' class that categorizes it as 'boolean'. This means it will now accommodate only true or false values.
Added Default Value Handling
A 'default' attribute was introduced into the 'pick' class which now defaults to '0'. Wherever there's no provided value for 'type', it will now default to '0'.
Enhanced Conditional Logic in 'if' Statement
The logic inside an existing 'if' statement has been refined. Now, it has an additional check for whether certain options within the class are empty or not.
Code Re-arrangement for Efficiency
Some pieces of code have been relocated within a conditional block. This likely ensures that these code pieces are only executed when necessary, increasing efficiency.
@sc0ttkclark The change might have unexpected behavior for odd combinations of bidirectional fields AND taxonomy sync. Something to look at before editing further or committing the change. Perhaps would be easier to verify if the taxonomy sync and bidirectional sync logic were split into two new methods with necessary sanity checks at the start of each method.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
returnRelated GitHub issue(s)
#7334
Changelog text for these changes
Bug: Relationship Field Taxonomy Sync now works correctly and presents as checkbox. User Interface for taxonomies using this feature should be hidden in taxonomy Admin UI settings to avoid confusion, as changes relationship field will update core taxonomy, but core taxonomy user interfaces will not update relationship field. @pdclark
PR checklist