chore: remove undeeded metadata when applying k8s objects#9267
Merged
cdrage merged 1 commit intopodman-desktop:mainfrom Oct 8, 2024
Merged
chore: remove undeeded metadata when applying k8s objects#9267cdrage merged 1 commit intopodman-desktop:mainfrom
cdrage merged 1 commit intopodman-desktop:mainfrom
Conversation
### What does this PR do? * Removes undeeded metadata objects which are not applicable / not needed when applying a patch. This includes resourceVersion, UID, selfLink and creationTimestamp. These are automatically created when applying a resource if undefined / blank. * This change is needed as Kubernetes javascript client added serialization / checks with regards to creationTimestamps as well as other metadata objects from PR: kubernetes-client/javascript#1695 ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#9260 Closes podman-desktop#9262 ### How to test this PR? <!-- Please explain steps to verify the functionality, do not forget to provide unit/component tests --> - [X] Tests are covering the bug fix or the new feature 1. Edit any k8s yaml 2. Press apply 3. Success 4. Edit again 5. Press apply 6. Success Signed-off-by: Charlie Drage <[email protected]>
cdrage
requested review from
axel7083,
gastoner and
jeffmaury
and removed request for
a team
deboer-tim
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: remove undeeded metadata when applying k8s objects
What does this PR do?
needed when applying a patch. This includes resourceVersion, UID,
selfLink and creationTimestamp. These are automatically created when
applying a resource if undefined / blank.
serialization / checks with regards to creationTimestamps as well as
other metadata objects from PR: Properly parse metadata of custom Kubernetes objects kubernetes-client/javascript#1695
Screenshot / video of UI
Screen.Recording.2024-10-08.at.10.53.57.AM.mov
What issues does this PR fix or reference?
Closes #9260
Closes #9262
How to test this PR?
Signed-off-by: Charlie Drage [email protected]