Repository navigation
inspect --raw: skip the NewImage() step - #708
Merged
Merged
Conversation
Contributor
|
LGTM |
mtrmac
reviewed
Aug 28, 2019
Skip the NewImage() step if we're just inspecting the raw manifest, so that if the tag or digest being inspected resolves to a manifest list, the local arch/OS combination doesn't need to be found in it to avoid an error. Signed-off-by: Nalin Dahyabhai <[email protected]>
Contributor
|
Thanks! LGTM pending tests. |
mtrmac
approved these changes
Aug 28, 2019
edsantiago
added a commit
to edsantiago/skopeo
that referenced
this pull request
Jan 21, 2021
Switch to using images from quay.io/libpod instead, where we're not (yet) subject to rate limiting. Completely rewrite one unclear test. The purpose of the test was to test podman-container-tools#708, in which 'skopeo inspect --raw' was fixed to be able to inspect images that do not match the current host's os+arch. We now use a fixed test image on quay.io, generated by a new script, whose manifest is pretty unlikely to match our host. Signed-off-by: Ed Santiago <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the
NewImage()step if we're just inspecting the raw manifest, so that if the image tag or digest being inspected resolves to a manifest list, the local arch/OS combination don't need to be found in it to avoid an error.