Merged
Conversation
lightovernight
force-pushed
the
gsoc-2025-debugger
branch
from
b38120a to
0a1f6dc
Compare
blueloveTH
reviewed
Jun 29, 2025
src/debugger/core.c
Outdated
|
|
||
| inline static py_Ref get_variable(int var_ref) { | ||
| assert(var_ref < py_list_len(py_r7()) && var_ref > 0); | ||
| return py_list_getitem(py_r7(), var_ref); |
Collaborator
There was a problem hiding this comment.
Don't hardcode r7, use a function instead.
src/debugger/core.c
Outdated
| const inline static char* prepend_workdir(const char* workdir, const char* path) { | ||
| static char full_path[512]; | ||
| if(!workdir || !path) return path; | ||
| snprintf(full_path, sizeof(full_path), "%s\\%s", workdir, path); |
Collaborator
There was a problem hiding this comment.
Why use \\ here? Is this windows specific?
| debugger.current_event = event; | ||
| debugger.current_filename = py_Frame_sourceloc(debugger.current_frame, &debugger.current_line); | ||
| clear_structures(); | ||
| if(event == TRACE_EVENT_LINE) return; |
Collaborator
There was a problem hiding this comment.
This event should be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.