Merged
Conversation
Contributor
Author
|
Not sure if this is the right way to go. The test passed locally. Please take a look. Thank you! @blueloveTH |
Collaborator
|
I just think this could be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this patch, we are making lz4 a submodule instead of including the source code itself. It would be beneficial to standardize the way we import third-party libraries; currently, libhv is a submodule and lz4 is source code.
Once this patch is implemented, we can ensure that all C source code added is written by pocketpy developers, making it easier to implement CI for checking code style.