avoid undefined behavior signed int overflow#318
Merged
blueloveTH merged 1 commit intopocketpy:mainfrom Dec 25, 2024
Merged
Conversation
Collaborator
|
I used to use your fixed version. However, I think We assert little endian. So I expect a "reinterpret". |
Contributor
Author
|
They do have different meaning, but both has only 6 asm after optimization, on all major compilers https://godbolt.org/z/fx6438EK8 https://godbolt.org/z/YKdjxsazc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows debug build runtime will check sighed overflow and popup a window