Skip to content

Add Patreon Auth#3323

Closed
ghostdevv wants to merge 4 commits intopocketbase:masterfrom
ghostdevv:patreon-auth
Closed

Add Patreon Auth#3323
ghostdevv wants to merge 4 commits intopocketbase:masterfrom
ghostdevv:patreon-auth

Conversation

@ghostdevv
Copy link
Copy Markdown
Contributor

I based this off the Yandex commit 435eca6#diff-0c7bbc200a025d45ef4358425b0a3c41b8de1e8b9d5f4b94a09f1d5c612e4481 - let me know if there is anything missing and I will add it to this pr! I tested this auth with the pocketbase js sdk and also running make test and make lint

@ghostdevv
Copy link
Copy Markdown
Contributor Author

Submitted a PR to the oauth2 package to add the patreon endpoints golang/oauth2#668

@ghostdevv
Copy link
Copy Markdown
Contributor Author

ghostdevv commented Sep 16, 2023

Just thought of something - it might be worth mentioning somewhere that it requires Patreon api v2 keys to be given

ganigeorgiev added a commit that referenced this pull request Sep 16, 2023
@ganigeorgiev
Copy link
Copy Markdown
Member

Thank you! I've tested the implementation locally, with both creator and regular user/subscriber, and everything seems to work fine.

To avoid the back-and-forth, I've squash merged it directly in the develop branch (71f9be3) (I've added only v2 to the provider title).

If the Go team ended up merging the endpoints PR we can update it later, but even with the static endpoints is fine (at the end the userApiUrl will still be "hardcoded").

The change will be available with the next PocketBase v0.19.0 release, but please note that there are no fixed ETAs yet (see also #3271). If you want to generate a static binary from the develop branch similar to the releases prebuilt executables, you can:

  1. Checkout or clone the develop branch
    git clone https://github.com/pocketbase/pocketbase.git --branch develop --single-branch
  2. Navigate to examples/base
  3. Run GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build (https://go.dev/doc/install/source#environment)
  4. Start the created executable by running ./base serve.

@ghostdevv
Copy link
Copy Markdown
Contributor Author

Ty!

@thisni1s thisni1s mentioned this pull request Sep 20, 2023
@s-li1 s-li1 mentioned this pull request May 28, 2024
ahmed-khaire pushed a commit to ahmed-khaire/postgresbase that referenced this pull request Aug 7, 2024
gopherbot pushed a commit to golang/oauth2 that referenced this pull request Feb 6, 2025
Adds the patreon endpoints from their documentation.

https://docs.patreon.com/#oauth.

I've tested these thoroughly whilst making a pr to pocketbase.

pocketbase/pocketbase#3323.

Change-Id: I023871a4340ee4ebcba9fd808d4a8f0c081fc10e
GitHub-Last-Rev: 890ef05
GitHub-Pull-Request: #668
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/528640
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Jorropo <[email protected]>
Auto-Submit: Jorropo <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants