fix: address pnpm failing to prune hoisted dev dependencies#9786
Merged
fix: address pnpm failing to prune hoisted dev dependencies#9786
Conversation
|
💖 Thanks for opening this pull request! 💖 |
samchungy
changed the title
zkochan
approved these changes
Jul 23, 2025
KSXGitHub
approved these changes
Jul 23, 2025
Member
|
The failing test seems unrelated. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduced a bug where it switched out a reduce for a for loop. I'm not sure where to write tests here but I'm happy to if you could point me to where I could.
Tested this against my bug reproduction.
https://github.com/pnpm/pnpm/pull/8537/files#diff-494d01d2e936696b2af0a7338260c27cbc5fb00345ee2506a086d38f974b8365R242-R247
Resolves: #9782