Skip to content

fix(listing/json): empty filter should print empty array#9688

Merged
zkochan merged 4 commits intomainfrom
ls-json-filter-non-existing-should-return-an-empty-array-9672
Jun 26, 2025
Merged

fix(listing/json): empty filter should print empty array#9688
zkochan merged 4 commits intomainfrom
ls-json-filter-non-existing-should-return-an-empty-array-9672

Conversation

@KSXGitHub
Copy link
Copy Markdown
Contributor

@KSXGitHub KSXGitHub commented Jun 24, 2025

Fixes #9672

@KSXGitHub KSXGitHub requested a review from zkochan as a code owner June 24, 2025 18:29
@zkochan
Copy link
Copy Markdown
Member

zkochan commented Jun 26, 2025

It is weird. I see that the test passes but when I try it locally, nothing is printed.

@KSXGitHub
Copy link
Copy Markdown
Contributor Author

It is weird. I see that the test passes but when I try it locally, nothing is printed.

If you try it in the pnpm repo then it has packageManager defined. Try it in a repo without packageManager.

@zkochan zkochan merged commit 2893bb9 into main Jun 26, 2025
26 of 29 checks passed
@zkochan zkochan deleted the ls-json-filter-non-existing-should-return-an-empty-array-9672 branch June 26, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm ls --filter non-existing --json should return empty array

2 participants