fix(deploy): overrides contain peer dependencies#9604
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ghost
approved these changes
Jun 7, 2025
ghost
approved these changes
Jun 7, 2025
KSXGitHub
commented
Jun 9, 2025
Contributor
Author
KSXGitHub
left a comment
KSXGitHub
left a comment
There was a problem hiding this comment.
I'm not sure how to make a test for this.
zkochan
approved these changes
Jun 9, 2025
Member
zkochan
left a comment
zkochan
left a comment
There was a problem hiding this comment.
Why can't it just be the correct
zkochan
deleted the
deploy-outdated-lockfile-error-when-there-are-overrides-9595
branch
Contributor
Author
"correct" what? |
Member
|
Why can't the "overrides" field in the lockfile match the "overrides" in settings? |
Contributor
Author
|
It does. The problem is that the manifest will be tranformed even in frozen lockfile, leading to mismatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9595