feat: update injected packages after run#9100
Merged
Conversation
zkochan
requested changes
Feb 13, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 19 changed files in this pull request and generated no comments.
Files not reviewed (14)
- exec/plugin-commands-script-runners/package.json: Language not supported
- exec/plugin-commands-script-runners/tsconfig.json: Language not supported
- workspace/update-injected-packages/package.json: Language not supported
- workspace/update-injected-packages/tsconfig.json: Language not supported
- workspace/update-injected-packages/tsconfig.lint.json: Language not supported
- exec/plugin-commands-script-runners/src/runRecursive.ts: Evaluated as low risk
- exec/plugin-commands-script-runners/src/run.ts: Evaluated as low risk
- config/config/src/Config.ts: Evaluated as low risk
- fs/indexed-pkg-importer/src/index.ts: Evaluated as low risk
- config/config/src/types.ts: Evaluated as low risk
- .changeset/strange-cherries-promise.md: Evaluated as low risk
- pnpm-lock.yaml: Evaluated as low risk
- .changeset/ninety-masks-study.md: Evaluated as low risk
- exec/plugin-commands-script-runners/src/shouldUpdateInjectedPackagesAfterRun.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
workspace/update-injected-packages/src/DirPatcher.ts:83
- Ensure that the behavior of the applyDiff function is covered by tests.
export async function applyDiff (optimizedDirDiff: DirDiff, sourceDir: string, targetDir: string): Promise<void> {
zkochan
reviewed
Feb 20, 2025
KSXGitHub
commented
Feb 20, 2025
How could I even misunderstand my own code?! `Patcher.apply()` will never call stat on the files because they have all been loaded to calculate `Patcher.patch`. This test is therefore nonsense.
zkochan
reviewed
Feb 22, 2025
zkochan
reviewed
Feb 23, 2025
exec/plugin-commands-script-runners/test/shouldSyncInjectedDepsAfterScripts.test.ts
Outdated
Show resolved
Hide resolved
KSXGitHub
commented
Feb 23, 2025
zkochan
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9081