Skip to content

fix(lifecycle): properly quote args#9018

Merged
zkochan merged 4 commits intopnpm:mainfrom
yoursunny:v10-lifecycle-quote
Jan 29, 2025
Merged

fix(lifecycle): properly quote args#9018
zkochan merged 4 commits intopnpm:mainfrom
yoursunny:v10-lifecycle-quote

Conversation

@yoursunny
Copy link
Copy Markdown
Contributor

fixes #8980
fixes #7641

@yoursunny yoursunny requested a review from zkochan as a code owner January 28, 2025 20:18
@yoursunny
Copy link
Copy Markdown
Contributor Author

Given that v10 has been released, this is a replacement of #8986 that targets v10 branch instead v9 branch.

Currently, the fixes are only applied to non-Windows platform.
Apparently, it is impossible to quote a command line argument that contains newline for Windows cmd.

@socket-security
Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@pnpm.e2e/[email protected] None 0 0 B
npm/[email protected] environment, network 0 292 kB nickuraltsev
npm/[email protected] Transitive: eval +3 559 kB medikoo
npm/[email protected] 🔁 npm/[email protected] None +5 408 kB
npm/[email protected] 🔁 npm/[email protected] None +20 890 kB dougwilson
npm/[email protected] 🔁 npm/[email protected] Transitive: eval +50 1.69 MB dougwilson
npm/[email protected] None 0 474 B coolaj86
npm/[email protected] None 0 6.27 kB leo
npm/[email protected] Transitive: environment, eval +49 6.73 MB zkochan
npm/[email protected] environment +2 4.6 MB gnoff
npm/[email protected] environment +1 322 kB gnoff
npm/[email protected] filesystem +1 65.9 kB isaacs
npm/[email protected] Transitive: environment +12 1.42 MB nfroidure
npm/[email protected] Transitive: environment, eval, filesystem, network, shell +28 1.28 MB zkochan
npm/[email protected] None 0 68.8 MB typescript-bot
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] filesystem, unsafe Transitive: environment, eval, network, shell +188 15.2 MB sokra
npm/[email protected] environment, filesystem, network, unsafe Transitive: eval, shell +72 15.7 MB sokra
npm/[email protected] Transitive: environment, filesystem +24 1.88 MB sindresorhus

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@changesets/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@eslint/[email protected], npm/@eslint/[email protected], npm/@gwhitney/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@reflink/[email protected], npm/@rushstack/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@yao-pkg/[email protected], npm/@yarnpkg/[email protected], npm/@yarnpkg/[email protected], npm/@yarnpkg/[email protected], npm/@yarnpkg/[email protected], npm/@yarnpkg/[email protected], npm/@yarnpkg/[email protected], npm/@zkochan/[email protected], npm/@zkochan/[email protected], npm/@zkochan/[email protected], npm/@zkochan/[email protected], npm/@zkochan/[email protected], npm/@zkochan/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@zkochan zkochan merged commit c0d1c01 into pnpm:main Jan 29, 2025
@welcome
Copy link
Copy Markdown

welcome bot commented Jan 29, 2025

Congrats on merging your first pull request! 🎉🎉🎉

zkochan pushed a commit that referenced this pull request Jan 29, 2025
* fix(lifecycle): properly quote args

close #8980
close #7641
@zkochan
Copy link
Copy Markdown
Member

zkochan commented Jun 10, 2025

This change caused an issue: #9381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm run transforms "\n" to "\\n" Multi-line arguments don't get forwarded correctly to scripts

2 participants