Skip to content

feat(git-resolver): respect proxy settings when resolving git#9016

Merged
zkochan merged 3 commits intopnpm:mainfrom
mato533:fix/git-resolve
Jan 28, 2025
Merged

feat(git-resolver): respect proxy settings when resolving git#9016
zkochan merged 3 commits intopnpm:mainfrom
mato533:fix/git-resolve

Conversation

@mato533
Copy link
Copy Markdown
Contributor

@mato533 mato533 commented Jan 27, 2025

Change to respect proxy settings when resolving git dependancies.
To do this, I have exchanged to fetchWithAgent instead of fetch and pass down pnpm options.

close: #6530

@mato533 mato533 requested a review from zkochan as a code owner January 27, 2025 17:55
@welcome
Copy link
Copy Markdown

welcome bot commented Jan 27, 2025

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 27, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +1 2.24 MB types
npm/@types/[email protected] None 0 3.69 kB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None +1 2.24 MB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None 0 5.43 kB types
npm/@types/[email protected] None 0 4.57 kB types
npm/@types/[email protected] None 0 2.62 kB types
npm/@types/[email protected] None 0 3.14 kB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None +2 253 kB types
npm/@types/[email protected] None 0 9.12 kB types
npm/@types/[email protected] None +1 870 kB types
npm/@types/[email protected] None +1 870 kB types
npm/@types/[email protected] None +1 31.7 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected], npm/@types/[email protected] None 0 1.97 MB types
npm/@types/[email protected] None 0 2.81 kB types
npm/@types/[email protected] None 0 6.67 kB types
npm/@types/[email protected] None 0 2.95 kB types
npm/@types/[email protected] None 0 3.25 kB types
npm/@types/[email protected] None 0 34.8 kB types
npm/@types/[email protected] None 0 7.57 kB types
npm/@types/[email protected] None +3 2.24 MB types
npm/@types/[email protected] None 0 23.8 kB types
npm/@types/[email protected] None 0 6.09 kB types
npm/@types/[email protected] None 0 3.49 kB types
npm/@types/[email protected] None +1 93 kB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None 0 4.67 kB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None +1 2.24 MB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None 0 6.67 kB types
npm/@types/[email protected] None 0 4.45 kB types
npm/@types/[email protected] None 0 6.06 kB types
npm/@types/[email protected] None +1 2.22 MB types
npm/@types/[email protected] None 0 3.71 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +16 6.12 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +9 1.47 MB jameshenry
npm/@yao-pkg/[email protected] environment, filesystem, shell, unsafe Transitive: network +14 5.81 MB roberts_lando
npm/@yarnpkg/[email protected] environment, eval, filesystem, network, unsafe +31 5.54 MB yarnbot
npm/@yarnpkg/[email protected] None 0 35.9 kB yarnbot
npm/@yarnpkg/[email protected] environment, eval, filesystem 0 280 kB arcanis
npm/@yarnpkg/[email protected] Transitive: environment, eval, filesystem, network, unsafe +35 8.24 MB yarnbot
npm/@yarnpkg/[email protected] None 0 197 kB yarnbot
npm/@yarnpkg/[email protected] environment, filesystem, unsafe +2 2.82 MB yarnbot
npm/@zkochan/[email protected] environment 0 37.5 kB zkochan
npm/@zkochan/[email protected] environment 0 7.59 kB zkochan
npm/@zkochan/[email protected] Transitive: environment, filesystem +1 557 kB zkochan
npm/@zkochan/[email protected] None 0 15 kB zkochan
npm/@zkochan/[email protected] filesystem 0 2.87 kB zkochan
npm/@zkochan/[email protected] Transitive: eval +4 1.72 MB zkochan
npm/[email protected] filesystem 0 105 kB cthackers
npm/[email protected] None +2 17.1 kB mafintosh
npm/[email protected] None 0 8.42 kB substack
npm/[email protected] None 0 3.06 kB zkochan
npm/[email protected] filesystem +1 32.8 kB npm-cli-ops
npm/[email protected] None +1 80.4 kB rvagg
npm/[email protected] None +2 32.2 kB sindresorhus
npm/[email protected] filesystem, unsafe Transitive: shell +4 627 kB oss-bot
npm/[email protected] None +1 16.3 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected], npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] filesystem 0 3.9 kB zkochan
npm/[email protected] filesystem 0 3.92 kB zkochan
npm/[email protected] None +3 85.9 kB sindresorhus
npm/[email protected] environment 0 26.1 kB sibiraj-s
npm/[email protected] None 0 8.2 kB shannonmoeller
npm/[email protected] None 0 10.4 kB sindresorhus
npm/[email protected] environment 0 2.27 kB zkochan
npm/[email protected] None 0 2.54 kB zkochan
npm/[email protected] environment, filesystem +2 7.05 MB gustavohenke
npm/[email protected] environment 0 29.1 kB kentcdodds
npm/[email protected] environment, filesystem, shell 0 16.1 kB satazor
npm/[email protected] environment, filesystem, network Transitive: shell +84 5.72 MB jason-dent
npm/[email protected] None +2 13 kB zkochan
npm/[email protected] None 0 11.2 kB sindresorhus
npm/[email protected] filesystem, shell 0 23.6 kB lovell
npm/[email protected] None +2 366 kB foray1010
npm/[email protected] filesystem 0 6.09 kB zkochan
npm/[email protected] filesystem 0 5.18 kB zkochan
npm/[email protected] None 0 3.34 kB zkochan
npm/[email protected] environment +1 215 kB jonschlinkert
npm/[email protected] environment, filesystem, network, shell 0 133 kB evanw
npm/[email protected] None 0 3.79 kB sindresorhus
npm/[email protected] None +1 33.8 kB mightyiam
npm/[email protected] environment, filesystem, unsafe Transitive: eval +37 4.51 MB ljharb
npm/[email protected] filesystem +8 1.83 MB weiran.zsd
npm/[email protected] filesystem +3 793 kB mysticatea
npm/[email protected] None 0 72.5 kB eslint-community-bot
npm/[email protected] environment, filesystem Transitive: unsafe +29 7.83 MB eslintbot
npm/[email protected] filesystem 0 4.07 kB zkochan
npm/[email protected] filesystem +5 211 kB mrmlnc
npm/[email protected] None +1 10.8 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None 0 11.8 kB sindresorhus
npm/[email protected] None 0 54.9 kB ryanzim
npm/[email protected] environment, filesystem, shell +4 8.39 MB mafintosh
npm/[email protected] None 0 8.52 kB zkochan
npm/[email protected] network 0 8.74 kB sindresorhus
npm/[email protected] environment, filesystem Transitive: shell +3 92.3 kB gtramontina
npm/[email protected] None 0 4.19 kB zkochan
npm/[email protected] None +1 35.8 kB grantila

🚮 Removed packages: npm/@pnpm.e2e/[email protected], npm/@zkochan/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@mato533
Copy link
Copy Markdown
Contributor Author

mato533 commented Jan 27, 2025

I don't understand where to write test cases related to fetching by proxy.
If it is needed, I would appreciate experts of pnpm to help with some instruction or anything.

I still don't know where to write test cases related to fetching by proxy.
If that's what you need, I'd be happy to have a pnpm experts provide some guidance or help in any other way.

@zkochan zkochan merged commit d6a4ff1 into pnpm:main Jan 28, 2025
@welcome
Copy link
Copy Markdown

welcome bot commented Jan 28, 2025

Congrats on merging your first pull request! 🎉🎉🎉

zkochan pushed a commit that referenced this pull request Jan 28, 2025
@mato533 @zkochan
feat(git-resolver): respect proxy settings when resolving git (#9016)
3d9a560 
close: #6530
@mato533 mato533 deleted the fix/git-resolve branch January 28, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zkochan zkochan Awaiting requested review from zkochan zkochan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Respect proxy settings when resolving git dependencies

2 participants

@mato533 @zkochan